Attention is currently required from: Felix Held, Jason Glenesk, Matt DeVillier, Raul Rangel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75933?usp=email )
Change subject: [UNTESTED] soc/amd/common/block/acpi/ivrs: conditionally generate eMMC entry
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75933/comment/23fce5ad_d512d778 :
PS1, Line 12: Where the PCI_DEVFN(0x13, 1) is from is currently unclear to me. There
: is no PCI device 0x13 on bus 0 and the eMMC controller is also an MMIO
: device and not a PCI device.
It had Naresh confused too, who wrote code to probe for the device before adding it, which failed and caused Linux to fail booting. I think it's worth adding a comment in the code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75933?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00865cb7caf82547e89eb5e77817e3d8ca5d35dd
Gerrit-Change-Number: 75933
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 22 Jun 2023 19:59:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment