Attention is currently required from: Jakub Czapiga, Maximilian Brune, Nico Huber, Philipp Hug, ron minnich.
Julius Werner has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/79907?usp=email )
Change subject: [RFC] region: Hide struct region members
......................................................................
Patch Set 8:
(1 comment)
File src/arch/arm/fit_payload.c:
https://review.coreboot.org/c/coreboot/+/79907/comment/4628acc7_cbcd7ff6?usp... :
PS8, Line 3: /* FIXME: should use the high-level region api */
I don't think we have an actual maintainer for the FIT payload support. […]
The main point of FIT is to be able to bundle a flattened device tree (FDT) together with a kernel image, which is required for modern Arm Linux. FIT is the only way to boot straight into the kernel from coreboot on Arm(64). I would rather we not remove it if possible.
I don't really have time (as usual) but am familiar enough with this code to review things if I get around to it. It shouldn't be too hard to convert it to use region_create(), I hope.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79907?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I713be9cf0bab4c2e21113b55e7229ab50f06c6cf
Gerrit-Change-Number: 79907
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: coreboot org
coreboot.org@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 23 Aug 2024 05:29:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: coreboot org
coreboot.org@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com