Attention is currently required from: Elyes Haouas, Felix Held, Felix Singer, Jan Samek, Martin L Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75893?usp=email )
Change subject: doc/Makefile: Fix build dir setting ......................................................................
Patch Set 4: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75893/comment/e35de218_34d87273 : PS4, Line 9: The commit 4d8da8ed ("Docs: Update sphinx targets with the build directory") Line is too long.
https://review.coreboot.org/c/coreboot/+/75893/comment/6fc96413_0d9e3ec7 : PS4, Line 10: an user *a user*, because phonetically it starts with a consonant.
https://review.coreboot.org/c/coreboot/+/75893/comment/0fbf4ea3_c93f0d0a : PS4, Line 10: intending AFAICT, beings intend, a variable would be *intended*
https://review.coreboot.org/c/coreboot/+/75893/comment/11534295_5ebfb6b4 : PS4, Line 12: outside Technically it's possible on the make command line. What doesn't work is setting it in the environment. That before commit 4d8da8ed the `$(BUILDDIR)` in `Makefile.sphinx` was already overwritable shows this.
https://review.coreboot.org/c/coreboot/+/75893/comment/0099d8fd_8ae5dcd8 : PS4, Line 16: and make it writable. I assume this makes no difference, at least commit 4d8da8ed alone wouldn't explain it.