Attention is currently required from: Philipp Deppenwiese, Martin Roth, Angel Pons, Julius Werner.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51923 )
Change subject: security/tpm: Add option to init TPM in bootblock
......................................................................
Patch Set 6:
(1 comment)
File src/lib/bootblock.c:
https://review.coreboot.org/c/coreboot/+/51923/comment/faf93cf6_6d70edd0
PS6, Line 62: acpi_is_wakeup_s3
Ah, I guess because of the power_state thingy? It's something I need to backport from Broadwell to Lynx Point in order to unify both platforms.
Not really. One just needs to be careful in romstage where this gets cleared. It also needs to be implemented in bootblock: https://review.coreboot.org/c/coreboot/+/52929/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51923
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifacba5d9ab19b47968b4f2ed5731ded4aac55022
Gerrit-Change-Number: 51923
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 05 May 2021 12:55:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment