Attention is currently required from: Bora Guvendik, Subrata Banik, Maulik V Vaghela, Selma Bensaid, Tim Wawrzynczak. Hello build bot (Jenkins), Subrata Banik, Maulik V Vaghela, Selma Bensaid, Paul Menzel, Tim Wawrzynczak, Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61839
to look at the new patch set (#6).
Change subject: util/cbmem: Keep original Total Time calculation when no negative timestamps ......................................................................
util/cbmem: Keep original Total Time calculation when no negative timestamps
"Total time" calculation changed after CL 59555 to include "1st timestamp" value in the calculation. This patch restores original Total Time calculation where "1st timetamp" is subtracted from "jumping to kernel". If pre CPU reset timestamps are added (negative timestamps), "Total time" calculation still includes the pre-reset time as expected.
1) Before https://review.coreboot.org/c/coreboot/+/59555: 0:1st timestamp 225,897 1101:jumping to kernel 1,238,218 (16,316)
Total Time: 1,012,281
2) After https://review.coreboot.org/c/coreboot/+/59555: 0:1st timestamp 225,897 1101:jumping to kernel 1,238,218 (16,316)
Total Time: 1,238,178
3) After this patch: 0:1st timestamp 225,897 (0) 1101:jumping to kernel 1,238,218 (16,316)
Total Time: 1,012,281
BUG=none TEST=Boot to OS, check cbmem -t on Redrix board
Signed-off-by: Bora Guvendik bora.guvendik@intel.com Change-Id: I0442f796b03731df3b869aea32d40ed94cabdce0 --- M util/cbmem/cbmem.c 1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/61839/6