Attention is currently required from: Eric Herrmann, Jakub Czapiga, Jay Patel, Jérémy Compostella, Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75764?usp=email )
Change subject: mb/google/rex: Enable Fast V-Mode for MTL-U 28W
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Where do the GT I_{TRIP} and SA I_{TRIP} values come from ? The Power Map from May 23rd indicates 54 A and 27 A.
I'm referring to the doc number 640982 but unable to find the exact match as you have mentioned here. Can you please clarify
Here is the logic that I have applied based on my read from PDG and pick the reference value Icc Max and Icc max APP from the power_map sheet.
For performance:
```
IA Icc max.app (85A) < IA ITRIP = 91A <= IA Icc max (110A)
```
ITRIP is greater than IccMax.App and less than IccMax in FVM applications. It is determined by customer specific VR current monitor tolerance and current capability.
Questions for you:
1. Should we refer to the performance value or baseline value for VR config ?
2. Should we calculate the value as per the logic (explained above) or should we pick any particular col from the power_map sheet (between IccMax or ITRIP_NOM)
Please advice.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75764?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If834c1af8141a19fd2daae653579225b77cfa6c8
Gerrit-Change-Number: 75764
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Herrmann
eherrmann@chromium.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Jay Patel
jay2.patel@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Eric Herrmann
eherrmann@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Jay Patel
jay2.patel@intel.com
Gerrit-Comment-Date: Wed, 21 Jun 2023 08:00:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-MessageType: comment