John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Add Type-C IOM device ......................................................................
soc/intel/tigerlake: Add Type-C IOM device
This adds Type-C IO Manageability Engine device with HID INTC1072. It provides MMIO range from 0xfbc10000 with size 0x1600. Kernel IOM driver refers to this memory resource for port operations.
BUG=:b:156016218 TEST=Built and booted on Volteer.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ic733e831643bda6e052edf797ba0e6206eb4ddd3 --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/41762/1
diff --git a/src/soc/intel/tigerlake/acpi/tcss.asl b/src/soc/intel/tigerlake/acpi/tcss.asl index abdcb51..6ae5582 100644 --- a/src/soc/intel/tigerlake/acpi/tcss.asl +++ b/src/soc/intel/tigerlake/acpi/tcss.asl @@ -130,6 +130,18 @@
Scope (_SB.PCI0) { + Device (IOM) + { + Name (_HID, "INTC1072") + Name (_DDN, "Intel(R) Tiger Lake IO Manageability Engine") + /* + * IOM preserved MMIO range from 0xFBC10000 to 0xFBC11600. + */ + Name (_CRS, ResourceTemplate () { + Memory32Fixed (ReadWrite, IOM_BASE_ADDRESS, IOM_BASE_SIZE) + }) + } + /* * Operation region defined to access the IOM REGBAR. Get the MCHBAR in offset * 0x48 in B0:D0:F0. REGBAR Base address is in offset 0x7110 of MCHBAR.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Add Type-C IOM device ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@10 PS1, Line 10: Kernel IOM : driver What is the name of that driver?
Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Add Type-C IOM device ......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/tigerlake: Add Type-C IOM device Would be good to follow this up with some details on IOM such as below. Input Output Manager (IOM) is part of the Tiger Lake SoC that configures the Type-C Sub System (TCSS).
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@9 PS1, Line 9: IO Manageability Engine Intel Input Output Manager (IOM)
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@10 PS1, Line 10: Kernel IOM : driver refers to this memory resource for port operations. Separate paragraph about how the driver uses this would be helpful as well.
Input Output Manager (IOM) kernel driver reads relevant information such as Type-C port status (whether a device is connected to a Type-C port or not) and the activity type on the Type-C ports (such as USB, Display Port, Thunderbolt) using this memory resource.
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@10 PS1, Line 10: Kernel IOM : driver
What is the name of that driver?
"Intel Input Output Manager (IOM) driver"
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@13 PS1, Line 13: : Remove?
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... PS1, Line 136: Tiger Lake IO Manageability Engine Input Output Manager (IOM) driver
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... PS1, Line 137: /* : * IOM preserved MMIO range from 0xFBC10000 to 0xFBC11600. : */ one line?
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Duncan Laurie, Shamile Khan, Rajmohan Mani, Patrick Rudolph, Prashant Malani, Divya S Sasidharan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41762
to look at the new patch set (#2).
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager (IOM) device. ......................................................................
soc/intel/tigerlake: Configure Type-C Input Output Manager (IOM) device.
This adds Type-C Intel Input Output Manager(IOM) device with HID INTC1072. It provides MMIO range from 0xfbc10000 with size 0x1600. Intel Input Output Manager(IOM) kernel driver reads relevant information such as Type-C port status (whether a device is connected to a Type-C port or not) and the activity type on the Type-C ports (such as USB, Display Port, Thunderbolt) using this memory resource.
BUG=b:156016218 TEST=Built and booted on Volteer.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ic733e831643bda6e052edf797ba0e6206eb4ddd3 --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/41762/2
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Duncan Laurie, Shamile Khan, Rajmohan Mani, Patrick Rudolph, Prashant Malani, Divya S Sasidharan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41762
to look at the new patch set (#3).
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager (IOM) device. ......................................................................
soc/intel/tigerlake: Configure Type-C Input Output Manager (IOM) device.
This adds Type-C Intel Input Output Manager(IOM) device with HID INTC1072. It provides MMIO range from 0xfbc10000 with size 0x1600. Intel Input Output Manager(IOM) kernel driver reads relevant information such as Type-C port status (whether a device is connected to a Type-C port or not) and the activity type on the Type-C ports (such as USB, Display Port, Thunderbolt) using this memory resource.
BUG=b:156016218 TEST=Built and booted on Volteer.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ic733e831643bda6e052edf797ba0e6206eb4ddd3 --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/41762/3
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Duncan Laurie, Shamile Khan, Rajmohan Mani, Patrick Rudolph, Prashant Malani, Divya S Sasidharan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41762
to look at the new patch set (#4).
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager (IOM) device. ......................................................................
soc/intel/tigerlake: Configure Type-C Input Output Manager (IOM) device.
This adds Type-C Intel Input Output Manager(IOM) device with HID INTC1072. It provides MMIO range from 0xfbc10000 with size 0x1600. Intel Input Output Manager(IOM) kernel driver reads relevant information such as Type-C port status (whether a device is connected to a Type-C port or not) and the activity type on the Type-C ports (such as USB, Display Port, Thunderbolt) using this memory resource.
BUG=b:156016218 TEST=Built and booted on Volteer.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ic733e831643bda6e052edf797ba0e6206eb4ddd3 --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/41762/4
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager (IOM) device. ......................................................................
Patch Set 4:
(7 comments)
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@7 PS1, Line 7: soc/intel/tigerlake: Add Type-C IOM device
Would be good to follow this up with some details on IOM such as below. […]
Done
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@9 PS1, Line 9: IO Manageability Engine
Intel Input Output Manager (IOM)
Done
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@10 PS1, Line 10: Kernel IOM : driver refers to this memory resource for port operations.
Separate paragraph about how the driver uses this would be helpful as well. […]
Done
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@10 PS1, Line 10: Kernel IOM : driver
"Intel Input Output Manager (IOM) driver"
Done
https://review.coreboot.org/c/coreboot/+/41762/1//COMMIT_MSG@13 PS1, Line 13: :
Remove?
Done
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... PS1, Line 136: Tiger Lake IO Manageability Engine
Input Output Manager (IOM) driver
Done
https://review.coreboot.org/c/coreboot/+/41762/1/src/soc/intel/tigerlake/acp... PS1, Line 137: /* : * IOM preserved MMIO range from 0xFBC10000 to 0xFBC11600. : */
one line?
Done
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager (IOM) device. ......................................................................
Patch Set 4:
This change is ready for review.
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Duncan Laurie, Shamile Khan, Rajmohan Mani, Patrick Rudolph, Prashant Malani, Divya S Sasidharan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41762
to look at the new patch set (#5).
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device.
This adds Type-C Intel Input Output Manager(IOM) device with HID INTC1072. It provides MMIO range from 0xfbc10000 with size 0x1600. Intel Input Output Manager(IOM) kernel driver reads relevant information such as Type-C port status (whether a device is connected to a Type-C port or not) and the activity type on the Type-C ports (such as USB, Display Port, Thunderbolt) using this memory resource.
BUG=b:156016218 TEST=Built and booted on Volteer.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ic733e831643bda6e052edf797ba0e6206eb4ddd3 --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/41762/5
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
Patch Set 5:
Do not merge. To be along with kernel Input Output Manager driver.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
Patch Set 5:
Patch Set 5:
Do not merge. To be along with kernel Input Output Manager driver.
Verified with internal version of IOM driver and extcon driver that the IOM driver gets probed and is able to read the IOM_PORT_STATUS register successfully.
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
Patch Set 5: Code-Review+1
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Duncan Laurie, Shamile Khan, Rajmohan Mani, Patrick Rudolph, Prashant Malani, Divya S Sasidharan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41762
to look at the new patch set (#7).
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device.
This adds Type-C Intel Input Output Manager(IOM) device with HID INTC1072. It provides MMIO range from 0xfbc10000 with size 0x1600. Intel Input Output Manager(IOM) kernel driver reads relevant information such as Type-C port status (whether a device is connected to a Type-C port or not) and the activity type on the Type-C ports (such as USB, Display Port, Thunderbolt) using this memory resource.
BUG=b:156016218 TEST=Built and booted on Volteer.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ic733e831643bda6e052edf797ba0e6206eb4ddd3 --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/41762/7
Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41762/3/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/41762/3/src/soc/intel/tigerlake/acp... PS3, Line 137: /* : * IOM preserved MMIO range from 0xFBC10000 to 0xFBC11600. : */ one line?
Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41762/3/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/41762/3/src/soc/intel/tigerlake/acp... PS3, Line 137: /* : * IOM preserved MMIO range from 0xFBC10000 to 0xFBC11600. : */
one line?
Sorry. For some reason, I was looking at patchset 3.
Rajmohan Mani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
Patch Set 7: Code-Review+1
John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41762/3/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/41762/3/src/soc/intel/tigerlake/acp... PS3, Line 137: /* : * IOM preserved MMIO range from 0xFBC10000 to 0xFBC11600. : */
Sorry. For some reason, I was looking at patchset 3.
Done
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Duncan Laurie, Shamile Khan, Rajmohan Mani, Patrick Rudolph, Prashant Malani, Divya S Sasidharan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41762
to look at the new patch set (#9).
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device.
This adds Type-C Intel Input Output Manager(IOM) device with HID INTC1072. It provides MMIO range from 0xfbc10000 with size 0x1600. Intel Input Output Manager(IOM) kernel driver reads relevant information such as Type-C port status (whether a device is connected to a Type-C port or not) and the activity type on the Type-C ports (such as USB, Display Port, Thunderbolt) using this memory resource.
BUG=b:156016218 TEST=Verified with IOM driver and extcon driver that the IOM driver gets probed and is able to read the IOM_PORT_STATUS register successfully.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ic733e831643bda6e052edf797ba0e6206eb4ddd3 --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/41762/9
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Duncan Laurie, Shamile Khan, Rajmohan Mani, Patrick Rudolph, Prashant Malani, Divya S Sasidharan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41762
to look at the new patch set (#10).
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device.
This adds Type-C Intel Input Output Manager(IOM) device with HID INTC1072. It provides MMIO range from 0xfbc10000 with size 0x1600. Intel Input Output Manager(IOM) kernel driver reads relevant information such as Type-C port status (whether a device is connected to a Type-C port or not) and the activity type on the Type-C ports (such as USB, Display Port, Thunderbolt) using this memory resource.
BUG=b:156016218 TEST=Able to detect USB, TBT and USB4 on Volteer.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ic733e831643bda6e052edf797ba0e6206eb4ddd3 --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/41762/10
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
Patch Set 10: Code-Review+2
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device. ......................................................................
Patch Set 10: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Tim Wawrzynczak, Duncan Laurie, Shamile Khan, Rajmohan Mani, Patrick Rudolph, Prashant Malani, Divya S Sasidharan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41762
to look at the new patch set (#11).
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device ......................................................................
soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device
This adds Type-C Intel Input Output Manager(IOM) device with HID INTC1072. It provides MMIO range from 0xfbc10000 with size 0x1600. Intel Input Output Manager(IOM) kernel driver reads relevant information such as Type-C port status (whether a device is connected to a Type-C port or not) and the activity type on the Type-C ports (such as USB, Display Port, Thunderbolt) using this memory resource.
BUG=b:156016218 TEST=Able to detect USB, TBT and USB4 on Volteer.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ic733e831643bda6e052edf797ba0e6206eb4ddd3 --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/41762/11
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41762 )
Change subject: soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device ......................................................................
soc/intel/tigerlake: Configure Type-C Input Output Manager(IOM) device
This adds Type-C Intel Input Output Manager(IOM) device with HID INTC1072. It provides MMIO range from 0xfbc10000 with size 0x1600. Intel Input Output Manager(IOM) kernel driver reads relevant information such as Type-C port status (whether a device is connected to a Type-C port or not) and the activity type on the Type-C ports (such as USB, Display Port, Thunderbolt) using this memory resource.
BUG=b:156016218 TEST=Able to detect USB, TBT and USB4 on Volteer.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ic733e831643bda6e052edf797ba0e6206eb4ddd3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41762 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Reviewed-by: Rajmohan Mani rajmohan.mani@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 10 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Rajmohan Mani: Looks good to me, but someone else must approve John Zhao: Looks good to me, but someone else must approve Wonkyu Kim: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/acpi/tcss.asl b/src/soc/intel/tigerlake/acpi/tcss.asl index 3312b59..33c1107 100644 --- a/src/soc/intel/tigerlake/acpi/tcss.asl +++ b/src/soc/intel/tigerlake/acpi/tcss.asl @@ -318,6 +318,16 @@
Scope (_SB.PCI0) { + Device (IOM) + { + Name (_HID, "INTC1072") + Name (_DDN, "Intel(R) Tiger Lake Input Output Manager(IOM) driver") + /* IOM preserved MMIO range from 0xFBC10000 to 0xFBC11600. */ + Name (_CRS, ResourceTemplate () { + Memory32Fixed (ReadWrite, IOM_BASE_ADDRESS, IOM_BASE_SIZE) + }) + } + /* * Operation region defined to access the TCSS_DEVEN. Get the MCHBAR in offset * 0x48 in B0:D0:F0. TCSS device enable base address is in offset 0x7090 of MCHBAR.
-
John Zhao (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Rajmohan Mani (Code Review)
-
Tim Wawrzynczak (Code Review)
-
Wonkyu Kim (Code Review)