Attention is currently required from: Boris Mittelberg, Jayvik Desai, Kapil Porwal, Subrata Banik.
Caveh Jalali has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85449?usp=email )
Change subject: ec/google/chromeec: Add indexed IO support
......................................................................
Patch Set 5:
(1 comment)
File src/ec/google/chromeec/ec_lpc.c:
https://review.coreboot.org/c/coreboot/+/85449/comment/2e098dad_c4cbf96c?usp... :
PS5, Line 57: port
`port` is always `EC_GOOGLE_CHROMEEC_MEMMAP_INDEXED_IO_PORT`
so it can be dropped as a parameter. the name of the function
already suggests indexed IO.
do you expect callers to specify alternate ports?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85449?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6c1aab3fc914eb5af2736a8ea3adf447040905e0
Gerrit-Change-Number: 85449
Gerrit-PatchSet: 5
Gerrit-Owner: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Thu, 19 Dec 2024 01:26:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No