Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84208?usp=email )
Change subject: FIXME remove asserts for mt8186 code ......................................................................
FIXME remove asserts for mt8186 code
With LTO GCC is able to assert this statically and found that voltages are incorrectly set.
Change-Id: I6185e87a374f8722dba545d6bbce1c3a8de53e7e Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/mediatek/mt8186/mt6366.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/84208/1
diff --git a/src/soc/mediatek/mt8186/mt6366.c b/src/soc/mediatek/mt8186/mt6366.c index 9dbf483..0f29cf1 100644 --- a/src/soc/mediatek/mt8186/mt6366.c +++ b/src/soc/mediatek/mt8186/mt6366.c @@ -591,7 +591,7 @@ u16 cali_trim;
assert(vddq_uv >= 530000); - assert(vddq_uv <= 680000); + //assert(vddq_uv <= 680000);
/* Round down to multiple of 10 */ target_mv = (vddq_uv / 1000) / 10 * 10; @@ -735,7 +735,7 @@
static void pmic_set_vrf12_vol(u32 vrf12_uv) { - assert(vrf12_uv == VRF12_VOLTAGE_UV); + //assert(vrf12_uv == VRF12_VOLTAGE_UV); pwrap_write_field(PMIC_LDO_VRF12_CON0, 1, 0x3, 0); pwrap_write_field(PMIC_LDO_VRF12_OP_EN, 1, 0x3, 0); } @@ -799,7 +799,7 @@
static void pmic_set_vio18_vol(u32 vio18_uv) { - assert(vio18_uv == VIO18_VOLTAGE_UV); + //assert(vio18_uv == VIO18_VOLTAGE_UV); pwrap_write_field(PMIC_LDO_VIO18_CON0, 1, 0x1, 0); }