Attention is currently required from: Marx Wang, Marx Wang, Nick Vaccaro, Ren Kuo, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84124?usp=email )
Change subject: mb/google/brox/jubilant: Modify FP IRQ pin
......................................................................
Patch Set 8: -Code-Review
(1 comment)
File src/mainboard/google/brox/variants/jubilant/gpio.c:
https://review.coreboot.org/c/coreboot/+/84124/comment/e71356e1_dc4b30af?usp... :
PS8, Line 44: PPAD
Typo: PAD
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84124?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4a7ca07eab0dab234ab025cf77bbb8093b6b9d1
Gerrit-Change-Number: 84124
Gerrit-PatchSet: 8
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Bob Moragues
moragues@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kenneth Chan
kenneth.chan@quanta.corp-partner.google.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Marx Wang
marx.wang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Marx Wang
marx.wang@intel.corp-partner.google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Fri, 30 Aug 2024 15:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes