Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support - coreboot-gerrit

21 Mar 2022


      Attention is currently required from: Felix Singer, Michał Żygowski, Michał Kopeć.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 )
Change subject: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/clevo/tgl-u/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/62498/comment/40d28377_cf2d834b 
PS1, Line 58: 	register "LpmStateDisableMask" = "
            : 		LPM_S0i2_1 |
            : 		LPM_S0i2_2 |
            : 		LPM_S0i3_1 |
            : 		LPM_S0i3_2 |
            : 		LPM_S0i3_3 |
            : 		LPM_S0i3_4
            :
...
Yes, but it does not handle the LPM_S0i2_1. […]
Why does s0i2.1 it have to be disabled on that board?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62498
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc
Gerrit-Change-Number: 62498
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Comment-Date: Mon, 21 Mar 2022 17:34:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski michal.zygowski@3mdeb.com
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment