Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard ......................................................................
Patch Set 30: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/40581/30//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40581/30//COMMIT_MSG@37 PS30, Line 37: - Everything else works Dots at the end please.
https://review.coreboot.org/c/coreboot/+/40581/30//COMMIT_MSG@40 PS30, Line 40: - Missing libgfxinit support Please elaborate what is missing? libgfxinit does not support the device?
https://review.coreboot.org/c/coreboot/+/40581/30//COMMIT_MSG@41 PS30, Line 41: - Missing flashrom support Also from coreboot? Any idea what is missing?
https://review.coreboot.org/c/coreboot/+/40581/30//COMMIT_MSG@42 PS30, Line 42: - Different configuration switches mentioned in ramstage.c Dot/period at the end.