Iru Cai has posted comments on this change. ( https://review.coreboot.org/23651 )
Change subject: mainboard/hp: Add HP Elitebook 8770w ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/Makefile.inc File src/mainboard/hp/8770w/Makefile.inc:
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/Makefile.inc@... PS1, Line 18: ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads no libgfxinit in this board
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/devicetree.cb File src/mainboard/hp/8770w/devicetree.cb:
https://review.coreboot.org/#/c/23651/1/src/mainboard/hp/8770w/devicetree.cb... PS1, Line 119: register "ec_fan_ctrl_value" = "0x6b" I found ec_fan_ctrl_value is 0x81 in one of the firmware update image (http://ftp.hp.com/pub/softpaq/sp57501-58000/sp57870.tgz) with the script in https://www.coreboot.org/HP_Elitebook.
Other values may be ok (and the OEM firmware can set it to 0xff on some condition), but I don't know the effect of this value.