Attention is currently required from: Elyes Haouas, Felix Singer, Jérémy Compostella, Vasiliy Khoruzhick, yuchi.chen@intel.com.
Shuo Liu has posted comments on this change by yuchi.chen@intel.com. ( https://review.coreboot.org/c/coreboot/+/83321?usp=email )
Change subject: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC
......................................................................
Patch Set 15:
(1 comment)
File src/soc/intel/snowridge/lockdown.c:
https://review.coreboot.org/c/coreboot/+/83321/comment/6d87ff6a_a8ea3aa5?usp... :
PS15, Line 22: if (chipset_lockdown == CHIPSET_LOCKDOWN_COREBOOT)
is CHIPSET_LOCKDOWN_FSP be tested? If no, we could just assert only support coreboot lockdown?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83321?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32ad836dfaaff0d1816eac41e5a7d19ece11080f
Gerrit-Change-Number: 83321
Gerrit-PatchSet: 15
Gerrit-Owner: yuchi.chen@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Vasiliy Khoruzhick
vasilykh@arista.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: yuchi.chen@intel.com
Gerrit-Attention: Vasiliy Khoruzhick
vasilykh@arista.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 27 Aug 2024 08:35:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No