Change in coreboot[master]: LinuxBoot: fix `make clean` for linux builds
Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35438 ) Change subject: LinuxBoot: fix `make clean` for linux builds ...................................................................... LinuxBoot: fix `make clean` for linux builds The kernel_dir variable was never correct, because targets/linux.mk is using build directories based on the version e.g. kernel_4.19.73. Change-Id: I749200bd32d86303ae02903afd96f730ac36b307 Signed-off-by: Alexander Couzens <lynxis@fe80.eu> --- M payloads/external/LinuxBoot/Makefile 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/35438/1 diff --git a/payloads/external/LinuxBoot/Makefile b/payloads/external/LinuxBoot/Makefile index 5840e8e..8b81c8a 100644 --- a/payloads/external/LinuxBoot/Makefile +++ b/payloads/external/LinuxBoot/Makefile @@ -14,7 +14,6 @@ ## project_dir=linuxboot -kernel_dir=$(project_dir)/kernel unexport $(COREBOOT_EXPORTS) @@ -65,7 +64,7 @@ linuxboot: kernel initramfs_compressed clean: - if [ -d "$(kernel_dir)" ]; then rm -rf $(kernel_dir); fi + rm -rf $(project_dir)/kernel* rm -f $(project_dir)/u-root rm -f $(project_dir)/initramfs* -- To view, visit https://review.coreboot.org/c/coreboot/+/35438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I749200bd32d86303ae02903afd96f730ac36b307 Gerrit-Change-Number: 35438 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Couzens <lynxis@fe80.eu> Gerrit-MessageType: newchange
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35438 ) Change subject: LinuxBoot: fix `make clean` for linux builds ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/35438 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I749200bd32d86303ae02903afd96f730ac36b307 Gerrit-Change-Number: 35438 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus@9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Fri, 22 May 2020 16:56:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/35438?usp=email ) Change subject: LinuxBoot: fix `make clean` for linux builds ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/35438?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I749200bd32d86303ae02903afd96f730ac36b307 Gerrit-Change-Number: 35438 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Jens Drenhaus <jens.drenhaus@9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-MessageType: abandon
participants (3)
-
Alexander Couzens (Code Review) -
Angel Pons (Code Review) -
Martin L Roth (Code Review)