Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/47729 )
Change subject: Make do_exit_flag static ......................................................................
Make do_exit_flag static
It does not be globally visible
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: I81d06f8803cd9c5ca6877a1e3d19287a681f5612 --- M em100.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/29/47729/1
diff --git a/em100.c b/em100.c index 580290a..e0b145a 100644 --- a/em100.c +++ b/em100.c @@ -29,7 +29,7 @@ char *database_version; int debug = 0;
-volatile int do_exit_flag = 0; +static volatile int do_exit_flag = 0;
static void exit_handler(int sig __unused) {
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/em100/+/47729 )
Change subject: Make do_exit_flag static ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/em100/+/47729/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/em100/+/47729/1//COMMIT_MSG@9 PS1, Line 9: not be not *need to* be
Hello build bot (Jenkins), Patrick Georgi, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/em100/+/47729
to look at the new patch set (#2).
Change subject: Make do_exit_flag static ......................................................................
Make do_exit_flag static
It does not need to be globally visible
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: I81d06f8803cd9c5ca6877a1e3d19287a681f5612 --- M em100.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/em100 refs/changes/29/47729/2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/47729 )
Change subject: Make do_exit_flag static ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/em100/+/47729/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/em100/+/47729/1//COMMIT_MSG@9 PS1, Line 9: not be
not *need to* be
Done
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/47729 )
Change subject: Make do_exit_flag static ......................................................................
Make do_exit_flag static
It does not need to be globally visible
Signed-off-by: Stefan Reinauer stefan.reinauer@coreboot.org Change-Id: I81d06f8803cd9c5ca6877a1e3d19287a681f5612 Reviewed-on: https://review.coreboot.org/c/em100/+/47729 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M em100.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/em100.c b/em100.c index 580290a..e0b145a 100644 --- a/em100.c +++ b/em100.c @@ -29,7 +29,7 @@ char *database_version; int debug = 0;
-volatile int do_exit_flag = 0; +static volatile int do_exit_flag = 0;
static void exit_handler(int sig __unused) {
-
Angel Pons (Code Review) -
Stefan Reinauer (Code Review)