Change in coreboot[master]: soc/mediatek/mt8192: Add a dummy EMI driver

[CK HU (Code Review)]

CK HU has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43961 )

Change subject: soc/mediatek/mt8192: Add a dummy EMI driver
......................................................................

soc/mediatek/mt8192: Add a dummy EMI driver

Add minimal function to report SDRAM size.

Signed-off-by: CK Hu 
Change-Id: If74b6b52dd6e91d1ff40cf8460b6a03b2f3bb6f6
---
A src/soc/mediatek/mt8192/emi.c
A src/soc/mediatek/mt8192/include/soc/emi.h
2 files changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/43961/1

diff --git a/src/soc/mediatek/mt8192/emi.c b/src/soc/mediatek/mt8192/emi.c
new file mode 100644
index 0000000..7b1d3c2
--- /dev/null
+++ b/src/soc/mediatek/mt8192/emi.c
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <soc/emi.h>
+
+size_t sdram_size(void)
+{
+	size_t dram_size = 0x100000000;
+
+	return dram_size;
+}
diff --git a/src/soc/mediatek/mt8192/include/soc/emi.h b/src/soc/mediatek/mt8192/include/soc/emi.h
new file mode 100644
index 0000000..0348573
--- /dev/null
+++ b/src/soc/mediatek/mt8192/include/soc/emi.h
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#ifndef SOC_MEDIATEK_MT8192_EMI_H
+#define SOC_MEDIATEK_MT8192_EMI_H
+
+#include <types.h>
+
+size_t sdram_size(void);
+
+#endif /* SOC_MEDIATEK_MT8192_EMI_H */

[CK HU (Code Review)]

Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43961

to look at the new patch set (#3).

Change subject: soc/mediatek/mt8192: Add a dummy EMI driver
......................................................................

soc/mediatek/mt8192: Add a dummy EMI driver

Add minimal function to report SDRAM size.

Signed-off-by: CK Hu 
Change-Id: If74b6b52dd6e91d1ff40cf8460b6a03b2f3bb6f6
---
A src/soc/mediatek/mt8192/emi.c
A src/soc/mediatek/mt8192/include/soc/emi.h
2 files changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/43961/3

[CK HU (Code Review)]

Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43961

to look at the new patch set (#4).

Change subject: soc/mediatek/mt8192: Add a dummy EMI driver
......................................................................

soc/mediatek/mt8192: Add a dummy EMI driver

Add minimal function to report SDRAM size.

Signed-off-by: CK Hu 
Change-Id: If74b6b52dd6e91d1ff40cf8460b6a03b2f3bb6f6
---
A src/soc/mediatek/mt8192/emi.c
A src/soc/mediatek/mt8192/include/soc/emi.h
2 files changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/43961/4

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43961 )

Change subject: soc/mediatek/mt8192: Add a dummy EMI driver
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43961/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43961/5//COMMIT_MSG@7 
PS5, Line 7: dummy
for inclusive language, please change "dummy" to

placeholder for the

[CK HU (Code Review)]

CK HU has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43961 )

Change subject: soc/mediatek/mt8192: Add a dummy EMI driver
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43961/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43961/5//COMMIT_MSG@7 
PS5, Line 7: dummy
> for inclusive language, please change "dummy" to […]

Ack

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43961 )

Change subject: soc/mediatek/mt8192: Add a dummy EMI driver
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43961/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43961/5//COMMIT_MSG@7 
PS5, Line 7: dummy
> Ack

not changed in PS6?

Change in coreboot[master]: soc/mediatek/mt8192: Add a placeholder for the EMI driver

[CK HU (Code Review)]

Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43961

to look at the new patch set (#7).

Change subject: soc/mediatek/mt8192: Add a placeholder for the EMI driver
......................................................................

soc/mediatek/mt8192: Add a placeholder for the EMI driver

Add minimal function to report SDRAM size.

Signed-off-by: CK Hu 
Change-Id: If74b6b52dd6e91d1ff40cf8460b6a03b2f3bb6f6
---
A src/soc/mediatek/mt8192/emi.c
A src/soc/mediatek/mt8192/include/soc/emi.h
2 files changed, 20 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/43961/7

Change in coreboot[master]: soc/mediatek/mt8192: Add a placeholder for the EMI driver

[CK HU (Code Review)]

CK HU has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43961 )

Change subject: soc/mediatek/mt8192: Add a placeholder for the EMI driver
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43961/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43961/5//COMMIT_MSG@7 
PS5, Line 7: dummy
> not changed in PS6?

Done

Change in coreboot[master]: soc/mediatek/mt8192: Add a placeholder for the EMI driver

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43961 )

Change subject: soc/mediatek/mt8192: Add a placeholder for the EMI driver
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: soc/mediatek/mt8192: Add a placeholder for the EMI driver

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43961 )

Change subject: soc/mediatek/mt8192: Add a placeholder for the EMI driver
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: soc/mediatek/mt8192: Add a placeholder for the EMI driver

[Hung-Te Lin (Code Review)]

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43961 )

Change subject: soc/mediatek/mt8192: Add a placeholder for the EMI driver
......................................................................

soc/mediatek/mt8192: Add a placeholder for the EMI driver

Add minimal function to report SDRAM size.

Signed-off-by: CK Hu 
Change-Id: If74b6b52dd6e91d1ff40cf8460b6a03b2f3bb6f6
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43961
Reviewed-by: Hung-Te Lin 
Reviewed-by: Yu-Ping Wu 
Tested-by: build bot (Jenkins) 
---
A src/soc/mediatek/mt8192/emi.c
A src/soc/mediatek/mt8192/include/soc/emi.h
2 files changed, 20 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Hung-Te Lin: Looks good to me, approved
  Yu-Ping Wu: Looks good to me, approved

diff --git a/src/soc/mediatek/mt8192/emi.c b/src/soc/mediatek/mt8192/emi.c
new file mode 100644
index 0000000..7b1d3c2
--- /dev/null
+++ b/src/soc/mediatek/mt8192/emi.c
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#include <soc/emi.h>
+
+size_t sdram_size(void)
+{
+	size_t dram_size = 0x100000000;
+
+	return dram_size;
+}
diff --git a/src/soc/mediatek/mt8192/include/soc/emi.h b/src/soc/mediatek/mt8192/include/soc/emi.h
new file mode 100644
index 0000000..0348573
--- /dev/null
+++ b/src/soc/mediatek/mt8192/include/soc/emi.h
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+
+#ifndef SOC_MEDIATEK_MT8192_EMI_H
+#define SOC_MEDIATEK_MT8192_EMI_H
+
+#include <types.h>
+
+size_t sdram_size(void);
+
+#endif /* SOC_MEDIATEK_MT8192_EMI_H */