Attention is currently required from: Raul Rangel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60253 )
Change subject: [RFC] smp/spinlock: Use compiler builtins ......................................................................
Patch Set 1:
(2 comments)
File src/include/smp/spinlock.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135894): https://review.coreboot.org/c/coreboot/+/60253/comment/487cafaf_ab548d7f PS1, Line 11: #define DECLARE_SPIN_LOCK(x) static struct spinlock x; macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-135894): https://review.coreboot.org/c/coreboot/+/60253/comment/c5a877fd_1fb3b6f2 PS1, Line 27: while (!spinlock_try_lock(lock)) { braces {} are not necessary for single statement blocks
-
build bot (Jenkins) (Code Review)