Daniel Kang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: [Do not merge] Separate power resource for VCM ......................................................................
[Do not merge] Separate power resource for VCM
WIP patch for discussion.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 50 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45159/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index dad762a..ad0b782 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -334,6 +334,54 @@ }) }
+ PowerResource (VCPR, 0x00, 0x0000) + { + Name (STA, Zero) + Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */ + { + If ((STA == Zero)) + { + /* Enable IMG_CLK */ + MCON(3,1) /* Clock 3, 19.2MHz */ + + /* Pull RST low */ + CTXS(GPP_F15) + + /* Pull PWREN high */ + STXS(GPP_H20) + Sleep(2) /* reset pulse width */ + + /* Pull RST high */ + STXS(GPP_F15) + Sleep(1) /* t2 */ + + Store(1,STA) + } + } + Method (_OFF, 0, Serialized) /* VCPR_OFF: VCM Power Off */ + { + If ((STA == One)) + { + /* Disable IMG_CLK */ + Sleep(1) /* t0+t1 */ + MCOF(3) /* Clock 3 */ + + /* Pull RST low */ + CTXS(GPP_F15) + + /* Pull PWREN low */ + CTXS(GPP_H20) + + Store(0,STA) + } + } + Method (_STA, 0, NotSerialized) /* _STA: Status */ + { + Return (STA) + } + } + + Device (VCM0) { Name (_HID, "PRP0001") /* _HID: Hardware ID */ @@ -356,11 +404,11 @@ }) Name (_PR0, Package (0x01) /* _PR0: Power Resources for D0 */ { - RCPR + VCPR }) Name (_PR3, Package (0x01) /* _PR3: Power Resources for D3hot */ { - RCPR + VCPR }) Name (_DSD, Package (0x02) /* _DSD: Device-Specific Data */ {
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45159
to look at the new patch set (#2).
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
mb/google/volteer: Separate power resource for VCM
The camera privacy LED blinks during the boot and this gives a wrong impression to the users that the camera is being used during the power up. The blink happens when the camera module is probed and a series of kernel patches and coreboot patches are being submitted to resolve the issue. This is to separate the power resource for the VCM so that it can be controlled by the driver and suppress the LED turn on.
BUG=b:169049942 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 50 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45159/2
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 2:
asf
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45159/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/2/src/mainboard/google/voltee... PS2, Line 348: CTXS(GPP_F15) We'll need ``` #if CONFIG(BOARD_GOOGLE_VOLTEER) CTXS(GPP_F15) #else CTXS(GPP_D4) #endif ``` or similar here as well. Although these should probably be in some variant-specific gpio.h file.... but that's for another change.
https://review.coreboot.org/c/coreboot/+/45159/2/src/mainboard/google/voltee... PS2, Line 370: CTXS(GPP_F15) We'll need ``` #if CONFIG(BOARD_GOOGLE_VOLTEER) CTXS(GPP_F15) #else CTXS(GPP_D4) #endif ``` or similar here as well.
Hello build bot (Jenkins), Bingbu Cao, Patrick Georgi, Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Paul Menzel, Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45159
to look at the new patch set (#3).
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
mb/google/volteer: Separate power resource for VCM
The camera privacy LED blinks during the boot and this gives a wrong impression to the users that the camera is being used during the power up. The blink happens when the camera module is probed and a series of kernel patches and coreboot patches are being submitted to resolve the issue. This is to separate the power resource for the VCM so that it can be controlled by the driver and suppress the LED turn on.
BUG=b:169049942 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 56 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45159/3
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45159/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/2/src/mainboard/google/voltee... PS2, Line 348: CTXS(GPP_F15)
We'll need […]
Done
https://review.coreboot.org/c/coreboot/+/45159/2/src/mainboard/google/voltee... PS2, Line 370: CTXS(GPP_F15)
We'll need […]
Done
Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */ What happens if one does the following sequence: 1) Power on the sensor. 2) Power on the VCM. 3) Power off the sensor. 4) Communicate with the VCM.
Would the VCM still work?
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 347: If ((STA == Zero)) Looks like there is something wrong with indentation (spaces, no tabs) in all the code being added in this CL.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
What happens if one does the following sequence: […]
Is that something the kernel might try to do? If so, then no, this won't work. If that needs to happen, one way I can think of is to have both power resources utilize the same 'STA' Name; if we do that, then the sequence you state above should work, because STA will still be 1 after #3, and so the sensor & the VCM would still remain powered.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45159/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45159/3//COMMIT_MSG@12 PS3, Line 12: kernel patches Please add a reference to the Linux kernel patches.
https://review.coreboot.org/c/coreboot/+/45159/3//COMMIT_MSG@14 PS3, Line 14: This is to separate the power resource for the VCM so that it can be Please add a blank line above to separate the paragraphs.
Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
Is that something the kernel might try to do? If so, then no, this won't work. […]
Yes, these are separate devices and there is no ordering guarantee.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
Yes, these are separate devices and there is no ordering guarantee.
Gotcha. Then what we'll have to do is add a guard variable (reference count, like STA) for each "resource" in the on and off sequence that are shared with another PowerResource, which is what the drivers/intel/mipi_camera chip driver does, see https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src... (It's on my todo list to switch volteer over to that driver).
To me, that looks like the following will require guard variables: 1) Clock 3 2) RST GPIO 3) PWREN
What I would do then is create 2 new Methods for each of those (one to enable and one to disable; both of which check the value of the guard variable first and increment or decrement as appropriate), and change VCPR & RCPR to use those methods instead of directly calling `CTXS`, etc. or `MCON`/`MCOF`.
Let me know if this doesn't make sense, and I can write up some ASL here.
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 366: Store(1,STA) We're trying to move to ASL 2.0 syntax, so `STA = 1` will work here.
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 386: Store(0,STA) We're trying to move to ASL 2.0 syntax, so `STA = 0` will work here.
Hello build bot (Jenkins), Bingbu Cao, Patrick Georgi, Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Paul Menzel, Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45159
to look at the new patch set (#4).
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
mb/google/volteer: Separate power resource for VCM
The camera privacy LED blinks during the boot and this gives a wrong impression to the users that the camera is being used during the power up. The blink happens when the camera module is probed and a series of kernel patches and coreboot patches are being submitted to resolve the issue.
The kernel patches are submitted to the chromium gerit. https://chromium-review.googlesource.com 2403386 2403387 2403385 2403384 2403383 2403382 2403381 2403380
This is to separate the power resource for the VCM so that it can be controlled by the driver and suppress the LED turn on.
BUG=b:169049942 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 56 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45159/4
Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
Gotcha. […]
I just checked the VCM datasheet and I'd have to check the board and module schematics (would be nice if someone could point me to the right one for this board) for completeness, and AFAICT this VCM has neither any clock input nor any reset/power-on pins, so it should be enough to just control the power rails.
Otherwise the idea sounds good to me. Thanks.
Hello build bot (Jenkins), Bingbu Cao, Patrick Georgi, Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Paul Menzel, Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45159
to look at the new patch set (#5).
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
mb/google/volteer: Separate power resource for VCM
The camera privacy LED blinks during the boot and this gives a wrong impression to the users that the camera is being used during the power up. The blink happens when the camera module is probed and a series of kernel patches and coreboot patches are being submitted to resolve the issue.
The kernel patches are submitted to the chromium gerit. https://chromium-review.googlesource.com 2403386 2403387 2403385 2403384 2403383 2403382 2403381 2403380
This is to separate the power resource for the VCM so that it can be controlled by the driver and suppress the LED turn on.
BUG=b:169049942 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 61 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45159/5
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
I just checked the VCM datasheet and I'd have to check the board and module schematics (would be nic […]
We need to go to SSDT anyway so can we leave DSDT as for now without adding a guard variable?
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 347: If ((STA == Zero))
Looks like there is something wrong with indentation (spaces, no tabs) in all the code being added i […]
Done
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 366: Store(1,STA)
We're trying to move to ASL 2.0 syntax, so `STA = 1` will work here.
Done
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 386: Store(0,STA)
We're trying to move to ASL 2.0 syntax, so `STA = 0` will work here.
Done
Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
We need to go to SSDT anyway so can we leave DSDT as for now without adding a guard variable?
Sorry, I don't know anything about SSDT, could you elaborate what effort is planned and what's the ETA?
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
Sorry, I don't know anything about SSDT, could you elaborate what effort is planned and what's the E […]
Tomasz, we are referring to coreboot generating AML at runtime and emitting it into the SSDT versus having ASL files directly in the DSDT. See CB:41758 for an example of converting jslrvp to this model. Using this driver will correctly generate enable and disable methods for each GPIO and clock that use reference counting to ensure proper power sequencing.
Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
Tomasz, we are referring to coreboot generating AML at runtime and emitting it into the SSDT versus […]
Okay, got it. Well, we can't leave this as is, because it can break any time, with a slight timing change in the kernel or the userspace.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45159/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/5/src/mainboard/google/voltee... PS5, Line 347: If ((STA == Zero)) maybe If (STA == 0)
https://review.coreboot.org/c/coreboot/+/45159/5/src/mainboard/google/voltee... PS5, Line 370: Store(1,STA) Please use ASL 2.0 syntax
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
Okay, got it. […]
Got it. Daniel, how critical is this?
Hello build bot (Jenkins), Bingbu Cao, Patrick Georgi, Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Paul Menzel, Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45159
to look at the new patch set (#6).
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
mb/google/volteer: Separate power resource for VCM
The camera privacy LED blinks during the boot and this gives a wrong impression to the users that the camera is being used during the power up. The blink happens when the camera module is probed and a series of kernel patches and coreboot patches are being submitted to resolve the issue.
The kernel patches are submitted to the chromium gerit. https://chromium-review.googlesource.com 2403386 2403387 2403385 2403384 2403383 2403382 2403381 2403380
This is to separate the power resource for the VCM so that it can be controlled by the driver and suppress the LED turn on.
BUG=b:169049942 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 75 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45159/6
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 6:
(3 comments)
Sorry for late response. I've just got back to this. Changed code to add reference check and etc. Also done with S0ix sanity check.
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... PS3, Line 345: Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */
Got it. […]
Sorry for late response. I've added reference counter (REFC). Also removed unnecessary steps in the VCM power up/down such as image clock on and off.
https://review.coreboot.org/c/coreboot/+/45159/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/5/src/mainboard/google/voltee... PS5, Line 347: If ((STA == Zero))
maybe If (STA == 0)
changed logic and this part is removed.
https://review.coreboot.org/c/coreboot/+/45159/5/src/mainboard/google/voltee... PS5, Line 370: Store(1,STA)
Please use ASL 2. […]
Done
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45159/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45159/3//COMMIT_MSG@12 PS3, Line 12: kernel patches
Please add a reference to the Linux kernel patches.
Done
https://review.coreboot.org/c/coreboot/+/45159/3//COMMIT_MSG@14 PS3, Line 14: This is to separate the power resource for the VCM so that it can be
Please add a blank line above to separate the paragraphs.
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 6: Code-Review+1
(6 comments)
https://review.coreboot.org/c/coreboot/+/45159/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45159/6//COMMIT_MSG@15 PS6, Line 15: gerit nit: ger*r*it
https://review.coreboot.org/c/coreboot/+/45159/6//COMMIT_MSG@32 PS6, Line 32: check it nit: check *if* it
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 162: CTXS(GPP_D4) Maybe the GPIO should be defined in some variant-specific header?
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 168: (( One set of parentheses is enough:
If (REFC == 0)
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 187: } \n
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 201: (( Same here, one set of parentheses is enough.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 7:
(9 comments)
https://review.coreboot.org/c/coreboot/+/45159/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45159/7//COMMIT_MSG@16 PS7, Line 16: https://chromium-review.googlesource.com : 2403386 : 2403387 : 2403385 : 2403384 : 2403383 : 2403382 : 2403381 : 2403380 suggestion: a link to just the first patch is fine, just say here's the beginning of the patchset supports this
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 149: Name (REFC, 0) Would you mind adding a comment here explaining what `REFC` is for?
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 168: If ((REFC == 0)) `If (REFC == 0)`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 175: REFC = REFC + 1 nit: ASL 2.0 supports `REFC++`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 206: REFC = REFC - 1 nit: ASL 2.0 supports `REFC--`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 352: If ((REFC == 0)) `If (REFC == 0)`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 357: REFC = REFC + 1 nit: `REFC++`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 362: If ((REFC == 1)) `If (REFC == 1)`
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 367: REFC = REFC - 1 nit: `REFC--`
Hello build bot (Jenkins), Bingbu Cao, Patrick Georgi, Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Paul Menzel, Angel Pons, Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45159
to look at the new patch set (#8).
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
mb/google/volteer: Separate power resource for VCM
The camera privacy LED blinks during the boot and this gives a wrong impression to the users that the camera is being used during the power up. The blink happens when the camera module is probed and a series of kernel patches and coreboot patches are being submitted to resolve the issue.
The kernel patches are submitted to the chromium gerit. https://chromium-review.googlesource.com/2403386 https://chromium-review.googlesource.com/2403386 https://chromium-review.googlesource.com/2403387 https://chromium-review.googlesource.com/2403385 https://chromium-review.googlesource.com/2403384 https://chromium-review.googlesource.com/2403383 https://chromium-review.googlesource.com/2403382 https://chromium-review.googlesource.com/2403381 https://chromium-review.googlesource.com/2403380
This is to separate the power resource for the VCM so that it can be controlled by the driver and suppress the LED turn on.
BUG=b:169049942 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 75 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45159/8
Hello build bot (Jenkins), Bingbu Cao, Patrick Georgi, Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Paul Menzel, Angel Pons, Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45159
to look at the new patch set (#9).
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
mb/google/volteer: Separate power resource for VCM
The camera privacy LED blinks during the boot and this gives a wrong impression to the users that the camera is being used during the power up. The blink happens when the camera module is probed and a series of kernel patches and coreboot patches are being submitted to resolve the issue.
The kernel patches are submitted to the chromium gerit. https://chromium-review.googlesource.com 2403386 2403387 2403385 2403384 2403383 2403382 2403381 2403380
This is to separate the power resource for the VCM so that it can be controlled by the driver and suppress the LED turn on.
BUG=b:169049942 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 78 insertions(+), 43 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45159/9
Hello build bot (Jenkins), Bingbu Cao, Patrick Georgi, Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Paul Menzel, Angel Pons, Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45159
to look at the new patch set (#10).
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
mb/google/volteer: Separate power resource for VCM
The camera privacy LED blinks during the boot and this gives a wrong impression to the users that the camera is being used during the power up. The blink happens when the camera module is probed and a series of kernel patches and coreboot patches are being submitted to resolve the issue.
The kernel patches are submitted to the chromium gerit.
https://chromium-review.googlesource.com/2403386 https://chromium-review.googlesource.com/2403387 https://chromium-review.googlesource.com/2403385 https://chromium-review.googlesource.com/2403384 https://chromium-review.googlesource.com/2403383 https://chromium-review.googlesource.com/2403382 https://chromium-review.googlesource.com/2403381 https://chromium-review.googlesource.com/2403380
This is to separate the power resource for the VCM so that it can be controlled by the driver and suppress the LED turn on.
BUG=b:169049942 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 78 insertions(+), 43 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45159/10
Hello build bot (Jenkins), Bingbu Cao, Patrick Georgi, Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Paul Menzel, Angel Pons, Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45159
to look at the new patch set (#11).
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
mb/google/volteer: Separate power resource for VCM
The camera privacy LED blinks during the boot and this gives a wrong impression to the users that the camera is being used during the power up. The blink happens when the camera module is probed and a series of kernel patches and coreboot patches are being submitted to resolve the issue.
The kernel patches are submitted to the chromium gerit.
https://chromium-review.googlesource.com/2403386 https://chromium-review.googlesource.com/2403387 https://chromium-review.googlesource.com/2403385 https://chromium-review.googlesource.com/2403384 https://chromium-review.googlesource.com/2403383 https://chromium-review.googlesource.com/2403382 https://chromium-review.googlesource.com/2403381 https://chromium-review.googlesource.com/2403380
This is to separate the power resource for the VCM so that it can be controlled by the driver and suppress the LED turn on.
BUG=b:169049942 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 77 insertions(+), 43 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45159/11
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 11:
(11 comments)
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 168: ((
One set of parentheses is enough: […]
Done
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 187: }
\n
Done
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 201: ((
Same here, one set of parentheses is enough.
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 149: Name (REFC, 0)
Would you mind adding a comment here explaining what `REFC` is for?
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 168: If ((REFC == 0))
`If (REFC == 0)`
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 175: REFC = REFC + 1
nit: ASL 2.0 supports […]
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 206: REFC = REFC - 1
nit: ASL 2.0 supports […]
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 352: If ((REFC == 0))
`If (REFC == 0)`
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 357: REFC = REFC + 1
nit: […]
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 362: If ((REFC == 1))
`If (REFC == 1)`
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 367: REFC = REFC - 1
nit: […]
Done
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45159/7//COMMIT_MSG@16 PS7, Line 16: https://chromium-review.googlesource.com : 2403386 : 2403387 : 2403385 : 2403384 : 2403383 : 2403382 : 2403381 : 2403380
suggestion: a link to just the first patch is fine, just say here's the beginning of the patchset su […]
Done
Hello build bot (Jenkins), Bingbu Cao, Patrick Georgi, Wonkyu Kim, Caveh Jalali, Tim Wawrzynczak, Paul Menzel, Angel Pons, Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45159
to look at the new patch set (#12).
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
mb/google/volteer: Separate power resource for VCM
The camera privacy LED blinks during the boot and this gives a wrong impression to the users that the camera is being used during the power up. The blink happens when the camera module is probed and a series of kernel patches and coreboot patches are being submitted to resolve the issue.
The kernel patches are submitted to the chromium gerrit.
https://chromium-review.googlesource.com/2403386 https://chromium-review.googlesource.com/2403387 https://chromium-review.googlesource.com/2403385 https://chromium-review.googlesource.com/2403384 https://chromium-review.googlesource.com/2403383 https://chromium-review.googlesource.com/2403382 https://chromium-review.googlesource.com/2403381 https://chromium-review.googlesource.com/2403380
This is to separate the power resource for the VCM so that it can be controlled by the driver and suppress the LED turn on.
BUG=b:169049942 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check if it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 77 insertions(+), 43 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/45159/12
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45159/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45159/6//COMMIT_MSG@15 PS6, Line 15: gerit
nit: ger*r*it
Done
https://review.coreboot.org/c/coreboot/+/45159/6//COMMIT_MSG@32 PS6, Line 32: check it
nit: check *if* it
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 162: CTXS(GPP_D4)
Maybe the GPIO should be defined in some variant-specific header?
We are dropping support for that variant, CB:46826
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 12: Code-Review+2
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 162: CTXS(GPP_D4)
We are dropping support for that variant, CB:46826
Correct.
Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 12: Code-Review+1
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
mb/google/volteer: Separate power resource for VCM
The camera privacy LED blinks during the boot and this gives a wrong impression to the users that the camera is being used during the power up. The blink happens when the camera module is probed and a series of kernel patches and coreboot patches are being submitted to resolve the issue.
The kernel patches are submitted to the chromium gerrit.
https://chromium-review.googlesource.com/2403386 https://chromium-review.googlesource.com/2403387 https://chromium-review.googlesource.com/2403385 https://chromium-review.googlesource.com/2403384 https://chromium-review.googlesource.com/2403383 https://chromium-review.googlesource.com/2403382 https://chromium-review.googlesource.com/2403381 https://chromium-review.googlesource.com/2403380
This is to separate the power resource for the VCM so that it can be controlled by the driver and suppress the LED turn on.
BUG=b:169049942 BRANCH=none TEST=Build and boot volteer board. Monitor camera privacy LED and check if it blinks. It should not blink.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: Id51c98e42c5f20e231d8096c9d2d98deebc7c968 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45159 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Tomasz Figa tfiga@google.com --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 77 insertions(+), 43 deletions(-)
Approvals: build bot (Jenkins): Verified Tomasz Figa: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index 51034c3..38cf14a 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -146,64 +146,69 @@
Scope (_SB.PCI0.I2C3) { + /* Reference counter to track power control by RCAM and VCM */ + Name (REFC, 0) PowerResource (RCPR, 0x00, 0x0000) { - Name (STA, Zero) + Name (STA, 0) Method (_ON, 0, Serialized) /* Rear camera_ON_: Power On */ { - If ((STA == Zero)) - { - /* Enable IMG_CLK */ - MCON(3,1) /* Clock 3, 19.2MHz */ + /* Enable IMG_CLK */ + MCON(3,1) /* Clock 3, 19.2MHz */
- /* Pull RST low */ + /* Pull RST low */ #if CONFIG(BOARD_GOOGLE_VOLTEER) - CTXS(GPP_F15) + CTXS(GPP_F15) #else - CTXS(GPP_D4) + CTXS(GPP_D4) #endif
- /* Pull SNRPWR_EN high */ - STXS(GPP_H14) + /* Pull SNRPWR_EN high */ + STXS(GPP_H14)
+ If (REFC == 0) + { /* Pull PWREN high */ STXS(GPP_H20) - Sleep(2) /* reset pulse width */ - - /* Pull RST high */ -#if CONFIG(BOARD_GOOGLE_VOLTEER) - STXS(GPP_F15) -#else - STXS(GPP_D4) -#endif - Sleep(1) /* t2 */ - - Store(1,STA) } + Sleep(2) /* reset pulse width */ + + REFC++ + + /* Pull RST high */ +#if CONFIG(BOARD_GOOGLE_VOLTEER) + STXS(GPP_F15) +#else + STXS(GPP_D4) +#endif + Sleep(1) /* t2 */ + + STA = 1 } Method (_OFF, 0, Serialized) /* Rear camera _OFF: Power Off */ { - If ((STA == One)) - { - /* Disable IMG_CLK */ - Sleep(1) /* t0+t1 */ - MCOF(3) /* Clock 3 */ + /* Disable IMG_CLK */ + Sleep(1) /* t0+t1 */ + MCOF(3) /* Clock 3 */
- /* Pull RST low */ + /* Pull RST low */ #if CONFIG(BOARD_GOOGLE_VOLTEER) - CTXS(GPP_F15) + CTXS(GPP_F15) #else - CTXS(GPP_D4) + CTXS(GPP_D4) #endif
+ If (REFC == 1) + { /* Pull PWREN low */ CTXS(GPP_H20) - - /* Pull SNRPWR_EN low */ - CTXS(GPP_H14) - - Store(0,STA) } + REFC-- + + /* Pull SNRPWR_EN low */ + CTXS(GPP_H14) + + STA = 0 } Method (_STA, 0, NotSerialized) /* _STA: Status */ { @@ -266,7 +271,7 @@ { "i2c-allow-low-power-probe", 0x01 - } + } } }) Name (PRT0, Package (0x04) @@ -339,6 +344,35 @@ }) }
+ PowerResource (VCPR, 0x00, 0x0000) + { + Name (STA, 0) + Method (_ON, 0, Serialized) /* VCPR_ON_: VCM Power On */ + { + If (REFC == 0) + { + /* Pull PWREN high */ + STXS(GPP_H20) + } + REFC++ + STA = 1 + } + Method (_OFF, 0, Serialized) /* VCPR_OFF: VCM Power Off */ + { + If (REFC == 1) + { + /* Pull PWREN low */ + CTXS(GPP_H20) + } + REFC-- + STA = 0 + } + Method (_STA, 0, NotSerialized) /* _STA: Status */ + { + Return (STA) + } + } + Device (VCM0) { Name (_HID, "PRP0001") /* _HID: Hardware ID */ @@ -361,11 +395,11 @@ }) Name (_PR0, Package (0x01) /* _PR0: Power Resources for D0 */ { - RCPR + VCPR }) Name (_PR3, Package (0x01) /* _PR3: Power Resources for D3hot */ { - RCPR + VCPR }) Name (_DSD, Package (0x02) /* _DSD: Device-Specific Data */ { @@ -381,7 +415,7 @@ { "i2c-allow-low-power-probe", 0x01 - } + } } }) } @@ -455,12 +489,12 @@
Scope (_SB.PCI0.I2C2) { + Name (STA, Zero) PowerResource (FCPR, 0x00, 0x0000) { - Name (STA, Zero) Method (_ON, 0, Serialized) /* Front camera_ON_: Power On */ { - If ((STA == Zero)) + If (STA == 0) { /* Enable IMG_CLK */ MCON(2,1) /* Clock 2, 19.2MHz */ @@ -479,12 +513,12 @@ STXS(GPP_D4) Sleep(1) /* t2 */
- Store(1,STA) + STA = 1 } } Method (_OFF, 0, Serialized) /* Front camera_OFF_: Power Off */ { - If ((STA == One)) + If (STA == 1) { /* Disable IMG_CLK */ Sleep(1) /* t0+t1 */ @@ -499,7 +533,7 @@ /* Pull SNRPWR_EN low */ CTXS(GPP_D18)
- Store(0,STA) + STA = 0 } } Method (_STA, 0, NotSerialized) /* _STA: Status */
-
Angel Pons (Code Review) -
Daniel Kang (Code Review)
-
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)
-
Tomasz Figa (Code Review)