[S] Change in coreboot[main]: mb/system76/mtl: darp10: Add TCSS configs - coreboot-gerrit

5 Sep 2024


      Attention is currently required from: Jeremy Soller, Paul Menzel.
Tim Crawford has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/83696?usp=email )
Change subject: mb/system76/mtl: darp10: Add TCSS configs
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/system76/mtl/variants/darp10/ramstage.c:
https://review.coreboot.org/c/coreboot/+/83696/comment/ab17a035_04983b18?usp... :
PS1, Line 10: BIT 6 is orientational
...
So it’s 0 below in 0x82. […]
This is an enable/disable bit. I don't know what enabling it actually does.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83696?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9bc6c5fc4c13bfa2e31ee1ce334b91e151373b6e
Gerrit-Change-Number: 83696
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Jeremy Soller jeremy@system76.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Thu, 05 Sep 2024 15:31:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org