Attention is currently required from: Hung-Te Lin, jitao shi, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55573 )
Change subject: soc/mediatek/mt8195: add eDP support ......................................................................
Patch Set 4:
(18 comments)
Patchset:
PS2:
src/soc/mediatek/mt8195/dptx_hal.c has no recognized SPDX identifier. […]
done
File src/soc/mediatek/mt8195/dp_intf.c:
https://review.coreboot.org/c/coreboot/+/55573/comment/eca4df1d_c614fbe2 PS2, Line 1: //
Use "/*" for consistency
Done
File src/soc/mediatek/mt8195/dptx.c:
https://review.coreboot.org/c/coreboot/+/55573/comment/b86067e5_dea8fe36 PS2, Line 388: static inline bool dptx_check_res_sample_rate(const struct edid *edid) {
open brace '{' following function definitions go on the next line […]
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/535e2fff_2b59b1f6 PS2, Line 494: * MISC 0/1 refernce to spec 1.4a p143 Table 2-96.
'refernce' may be misspelled - perhaps 'reference'? […]
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/72660378_959c033d PS2, Line 642: int* status_ctrl, int* iteration, u8 *dpcp_buffer,
"foo* bar" should be "foo *bar" […]
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/1fe99500_bbf4a0eb PS2, Line 642: int* status_ctrl, int* iteration, u8 *dpcp_buffer,
"foo* bar" should be "foo *bar" […]
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/f0b58d47_aa99f2fc PS2, Line 643: u8* dpcd206)
"foo* bar" should be "foo *bar" […]
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/4355aeeb_82a0a524 PS2, Line 705: int* status_ctrl, int* iteration, u8 *dpcp_buffer,
"foo* bar" should be "foo *bar" […]
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/e6f78bec_9ffaa96a PS2, Line 705: int* status_ctrl, int* iteration, u8 *dpcp_buffer,
"foo* bar" should be "foo *bar" […]
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/ec28e34d_3b180f04 PS2, Line 706: u8* dpcd206)
"foo* bar" should be "foo *bar" […]
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/42782990_6678347c PS2, Line 1134:
Extra blank line.
Done
File src/soc/mediatek/mt8195/dptx_hal.c:
https://review.coreboot.org/c/coreboot/+/55573/comment/2b376114_9d299e7c PS2, Line 1: GPL-2.0
GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/4eac3a34_5b580461 PS2, Line 1: //
Use "/*" for consistency
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/ce5dbb0b_9062db4f PS2, Line 178: switch(out_format) {
space required before the open parenthesis '(' […]
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/2a206c18_20752587 PS2, Line 583: for (lane = 0; lane < DPTX_LANE_MAX; lane ++)
space prohibited before that '++' (ctx:WxB) […]
Done
https://review.coreboot.org/c/coreboot/+/55573/comment/08ef366c_6392319a PS2, Line 586: for (lane = 0; lane < DPTX_LANE_MAX; lane ++)
space prohibited before that '++' (ctx:WxB) […]
Done
File src/soc/mediatek/mt8195/include/soc/dptx_reg.h:
https://review.coreboot.org/c/coreboot/+/55573/comment/5b9c30d8_0efa4c7a PS2, Line 65: #define VIDEO_RESET_SW_DP_ENCODER0_P0_FLDMASK_LEN 1
please, no space before tabs
done
https://review.coreboot.org/c/coreboot/+/55573/comment/7e6d503f_92c42a27 PS2, Line 191: #define HSP_SEL_DP_ENCODER0_P0_FLDMASK_POS 6
please, no space before tabs […]
Done
-
Rex-BC Chen (Code Review)