Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/22972 )
Change subject: mainboard/hp: Add Eliteboot Revolve 810 G1 ......................................................................
Patch Set 2:
(3 comments)
What doesn't work or needs to be implemented ?
https://review.coreboot.org/#/c/22972/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/22972/2//COMMIT_MSG@7 PS2, Line 7: mainboard/hp: Add Eliteboot Revolve 810 G1 Elitebook
https://review.coreboot.org/#/c/22972/2/src/mainboard/hp/revolve_810_g1/roms... File src/mainboard/hp/revolve_810_g1/romstage.c:
https://review.coreboot.org/#/c/22972/2/src/mainboard/hp/revolve_810_g1/roms... PS2, Line 18: #include <stdint.h> please remove obsolete headers
https://review.coreboot.org/#/c/22972/2/src/mainboard/hp/revolve_810_g1/roms... PS2, Line 91: void *spd_file = cbfs_boot_map_with_leak("spd.bin", CBFS_TYPE_SPD, please don't leak the file
-
Patrick Rudolph (Code Review)