Attention is currently required from: Paul Menzel. Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56380 )
Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56380/comment/708ac550_95023e20 PS1, Line 7: src/mainboard/google/octopus/variants/phaser
Please look at `git log --oneline` how prefixes are composed.
Done
https://review.coreboot.org/c/coreboot/+/56380/comment/23523528_32c8f82a PS1, Line 7: src/mainboard/google/octopus/variants/phaser:Change
Please add a space after the colon.
Done
https://review.coreboot.org/c/coreboot/+/56380/comment/606d9024_fbef285c PS1, Line 9: The change from Synaptics S7817 to Elan 3915N
What do you mean? The ELAN touchpad is already configured in the devicetree, isn’t it?
Yes,originally,this is defined by former engineers who worked on this project before, but we actually never used it.
https://review.coreboot.org/c/coreboot/+/56380/comment/82ce2883_f6250aab PS1, Line 9: The change from Synaptics S7817 to Elan 3915N and pin distribution of touch IC is the same. : : According to vendor spec definition IRQ trigger method needs to change to level.
Please wrap lines after 75 characters.
Done