Change in coreboot[master]: mb with INTEL_HASWELL: Remove double APM finalize call - coreboot-gerrit

9 Apr 2021


      Attention is currently required from: Angel Pons, Arthur Heymans.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52168 )
Change subject: mb with INTEL_HASWELL: Remove double APM finalize call
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
...
I guess this was done to allow the chipset to be finalized later. […]
The call in lpc_final() only happens with INTEL_CHIPSET_LOCKDOWN enabled, which depends on !CHROMEOS, while this is unconditional, no?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic615c39762840de1bd4583a359dd7da74f0ae062
Gerrit-Change-Number: 52168
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Georgi pgeorgi@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 09 Apr 2021 06:16:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment