Change in ...coreboot[master]: Revert "UPSTREAM: ec/google/wilco: Enable software sync for VBOOT"
Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32007
Change subject: Revert "UPSTREAM: ec/google/wilco: Enable software sync for VBOOT" ......................................................................
Revert "UPSTREAM: ec/google/wilco: Enable software sync for VBOOT"
This reverts commit 51169b7dda4a1978d622e329a1c40e384471c165.
I was not ready to enable this option yet, until it is enabled in depthcharge it needs to stay off in coreboot or depthcharge will attempt to do software sync without a proper driver.
Change-Id: I4840812d0541f822502cfc5c66bed27edf4d2ecc Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/ec/google/wilco/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/32007/1
diff --git a/src/ec/google/wilco/Kconfig b/src/ec/google/wilco/Kconfig index f4a4111..4202c1d 100644 --- a/src/ec/google/wilco/Kconfig +++ b/src/ec/google/wilco/Kconfig @@ -3,7 +3,6 @@ default n select EC_GOOGLE_COMMON_MEC select EC_ACPI - select VBOOT_EC_SOFTWARE_SYNC if VBOOT help Google Wilco Embedded Controller interface.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32007 )
Change subject: Revert "UPSTREAM: ec/google/wilco: Enable software sync for VBOOT" ......................................................................
Patch Set 1:
Bad timing when this landed, I will try again once the vboot/depthcharge work finishes.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32007 )
Change subject: Revert "UPSTREAM: ec/google/wilco: Enable software sync for VBOOT" ......................................................................
Patch Set 3: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32007 )
Change subject: Revert "UPSTREAM: ec/google/wilco: Enable software sync for VBOOT" ......................................................................
Revert "UPSTREAM: ec/google/wilco: Enable software sync for VBOOT"
This reverts commit 51169b7dda4a1978d622e329a1c40e384471c165.
I was not ready to enable this option yet, until it is enabled in depthcharge it needs to stay off in coreboot or depthcharge will attempt to do software sync without a proper driver.
Change-Id: I4840812d0541f822502cfc5c66bed27edf4d2ecc Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32007 Reviewed-by: Lijian Zhao lijian.zhao@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/ec/google/wilco/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Lijian Zhao: Looks good to me, approved
diff --git a/src/ec/google/wilco/Kconfig b/src/ec/google/wilco/Kconfig index f4a4111..4202c1d 100644 --- a/src/ec/google/wilco/Kconfig +++ b/src/ec/google/wilco/Kconfig @@ -3,7 +3,6 @@ default n select EC_GOOGLE_COMMON_MEC select EC_ACPI - select VBOOT_EC_SOFTWARE_SYNC if VBOOT help Google Wilco Embedded Controller interface.
-
Duncan Laurie (Code Review) -
Lijian Zhao (Code Review)