Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37621 )
Change subject: mb/google/nocturne: adjust VBT boot resolution ......................................................................
mb/google/nocturne: adjust VBT boot resolution
On nocturne, the VBT specifies that the native panel resolution (3000x2000) is to be used by FSP/GOP init, which makes payload and grub menus extremely difficult to read. Change the default POST resolution specified by the VBT to 1500x1000 instead (200% scaling) which is much more legible.
Test: build/boot nocturne with GOP init and Tianocore payload, observe menu text is actually readable. Signed-off-by: Matt DeVillier matt.devillier@gmail.com
Change-Id: I767a2b8319c7673e3460acfad534140409bf1d57 --- M src/mainboard/google/poppy/variants/nocturne/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/37621/1
diff --git a/src/mainboard/google/poppy/variants/nocturne/data.vbt b/src/mainboard/google/poppy/variants/nocturne/data.vbt index 4d9293e..4d89430 100644 --- a/src/mainboard/google/poppy/variants/nocturne/data.vbt +++ b/src/mainboard/google/poppy/variants/nocturne/data.vbt Binary files differ
Matt DeVillier has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/37621 )
Change subject: mb/google/nocturne: adjust VBT boot resolution ......................................................................
mb/google/nocturne: adjust VBT boot resolution
On nocturne, the VBT specifies that the native panel resolution (3000x2000) is to be used by FSP/GOP init, which makes payload and grub menus extremely difficult to read. Change the default POST resolution specified by the VBT to 1500x1000 instead (200% scaling) which is much more legible.
Test: build/boot nocturne with GOP init and Tianocore payload, observe menu text is actually readable.
Signed-off-by: Matt DeVillier matt.devillier@gmail.com Change-Id: I767a2b8319c7673e3460acfad534140409bf1d57 --- M src/mainboard/google/poppy/variants/nocturne/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/37621/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37621 )
Change subject: mb/google/nocturne: adjust VBT boot resolution ......................................................................
Patch Set 2: Code-Review+2
Oops, forgot about this change. I saw it on my emails, but never got to actually review it until now :S
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37621 )
Change subject: mb/google/nocturne: adjust VBT boot resolution ......................................................................
mb/google/nocturne: adjust VBT boot resolution
On nocturne, the VBT specifies that the native panel resolution (3000x2000) is to be used by FSP/GOP init, which makes payload and grub menus extremely difficult to read. Change the default POST resolution specified by the VBT to 1500x1000 instead (200% scaling) which is much more legible.
Test: build/boot nocturne with GOP init and Tianocore payload, observe menu text is actually readable.
Signed-off-by: Matt DeVillier matt.devillier@gmail.com Change-Id: I767a2b8319c7673e3460acfad534140409bf1d57 Reviewed-on: https://review.coreboot.org/c/coreboot/+/37621 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/poppy/variants/nocturne/data.vbt 1 file changed, 0 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/variants/nocturne/data.vbt b/src/mainboard/google/poppy/variants/nocturne/data.vbt index 4d9293e..4d89430 100644 --- a/src/mainboard/google/poppy/variants/nocturne/data.vbt +++ b/src/mainboard/google/poppy/variants/nocturne/data.vbt Binary files differ
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)