Attention is currently required from: Cliff Huang, Lance Zhao, Sergii Dmytruk, Tim Wawrzynczak.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80523?usp=email )
Change subject: acpi: publish control area of memory-mapped TPMs
......................................................................
Patch Set 1:
(1 comment)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/80523/comment/adcd0ec4_9b0ab59b :
PS1, Line 297: } else if (CONFIG(MEMORY_MAPPED_TPM)) {
: tpm2->control_area = CONFIG_TPM_TIS_BASE_ADDRESS;
: /* Must be set to 6 for Memory-mapped I/O Interface */
: tpm2->start_method = 6;
The MEMORY_MAPPED_TPM has no control area, so we just needed the `is_crb_active` in the IF condition above
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80523?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33c2f79028e1f066c0099216c314652ea46f5f84
Gerrit-Change-Number: 80523
Gerrit-PatchSet: 1
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Thu, 15 Feb 2024 08:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment