Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42794 )
Change subject: crossgcc: Allow GCC to get asan shadow offset at runtime ......................................................................
Patch Set 17: Code-Review+1
(5 comments)
OK, let's clean up some typos and bring this patch in.
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG@11 PS17, Line 11: , Not needed.
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG@11 PS17, Line 11: at each stage By "thus" a few words earlier you already mean "multiple stages". So no need to mention it here again, just skip these words.
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG@16 PS17, Line 16: a callback function Maybe better "... a callback function named __asan_shadow_offset()"?
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG@26 PS17, Line 26: the build fails "the build will fail."
https://review.coreboot.org/c/coreboot/+/42794/17//COMMIT_MSG@34 PS17, Line 34: , Not needed here.
-
Werner Zeh (Code Review)