Attention is currently required from: Subrata Banik, Paul Menzel, Angel Pons, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62699 )
Change subject: lib/spd: Do not print part number if it is not available
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62699/comment/41094cf5_877116e1
PS4, Line 11:
Can we please capture the output in the commit msg as well? (incase spd[DDR4_SPD_PART_OFF] == 0), wi […]
I do not see why displaying "unknown" will add value or more information to the log. Therefore, if there is no number available in the SPD data (spd[DDR4_SPD_PART_OFF] == 0) , the complete line will simply be dropped from the log (with this patch applied).
Until now, the log output looks like:
'[INFO ] SPD: module part number is '
which is, IMHO, not helpful at all and just leads to confusion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62699
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7224c6e114731b1c03915a2bde80f57369d0cee
Gerrit-Change-Number: 62699
Gerrit-PatchSet: 4
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 14 Mar 2022 09:36:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment