Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62793 )
Change subject: cpu/x86/smm: Add smm_get_cbmemc_buffer for legacy SMI handler ......................................................................
cpu/x86/smm: Add smm_get_cbmemc_buffer for legacy SMI handler
Fixes the following error when using the legacy SMI handler:
coreboot/util/crossgcc/xgcc/bin/i386-elf-ld.bfd: build/smm/smm.o: in function `cbmemc_init': coreboot/src/lib/cbmem_console.c:91: undefined reference to `smm_get_cbmemc_buffer'
BUG=b:221231786 TEST=none
Fixes: c5160986cf9 ("cpu/x86/smm,lib/cbmem_console: Enable CBMEMC when using DEBUG_SMI") Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I3ba4952d2d2a984adaf8fe3508e6b82d396aa9bb --- M src/cpu/x86/smm/smihandler.c 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/62793/1
diff --git a/src/cpu/x86/smm/smihandler.c b/src/cpu/x86/smm/smihandler.c index 0b262af..fe95a2d 100644 --- a/src/cpu/x86/smm/smihandler.c +++ b/src/cpu/x86/smm/smihandler.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <arch/io.h> +#include <console/cbmem_console.h> #include <console/console.h> #include <commonlib/region.h> #include <cpu/x86/smm.h> @@ -55,6 +56,13 @@ return (*((volatile unsigned long *)(LAPIC_ID)) >> 24); }
+void smm_get_cbmemc_buffer(void **buffer_out, size_t *size_out) +{ + /* Not supported with legacy SMI handler */ + *buffer_out = NULL; + *size_out = NULL; +} + void io_trap_handler(int smif) { /* If a handler function handled a given IO trap, it