Attention is currently required from: Tristan Corrick.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54375 )
Change subject: mb/asus/p8h61-m_lx: Transform into variant setup
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/asus/h61-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/54375/comment/da32a344_55143e88
PS2, Line 52: default "-S --whitelist EFFS,FCRS"
Should this default be only `if BOARD_ASUS_P8H61_M_LX`?
Hrm, strictly speaking it should be. However, P8H61-M PRO has issues with me_cleaner as per the docs: https://doc.coreboot.org/mainboard/asus/p8h61-m_pro.html#known-issues
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a02f32dfd9fa9c1adce3baf0d279ea19db5883f
Gerrit-Change-Number: 54375
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Comment-Date: Tue, 18 May 2021 15:07:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tristan Corrick
tristan@corrick.kiwi
Gerrit-MessageType: comment