Attention is currently required from: Andrey Pronin, Raul Rangel, Christian Walter, Karthik Ramasubramanian.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59479 )
Change subject: drivers/tpm: Add always-shutdown-on-suspend DSD property
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Here's the matching kernel patch(WIP): https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3...
File src/drivers/i2c/tpm/chip.c:
https://review.coreboot.org/c/coreboot/+/59479/comment/db70dabd_6bf523b3
PS2, Line 53: suspend
Should we name this s0ix so it's not confused with S3?
Technically it can apply to both S3 and S0i3. The flag just overrides the pm_suspend_via_firmware() check in tpm_pm_suspend. Turns out pm_suspend_via_firmware is used as a proxy for is_s3_suspend, but I don't want to repeat that assumption.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59479
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia48ead856fc0c6e637a2e07a5ecc58423f599c5b
Gerrit-Change-Number: 59479
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Andrey Pronin
apronin@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 18 Nov 2021 22:34:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment