Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/19684 )
Change subject: soc/intel/common: Add sanity check of PCR_BASE_ADDRESS ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19684/1/src/soc/intel/common/block/pcr/pcr.c File src/soc/intel/common/block/pcr/pcr.c:
PS1, Line 27: #if(CONFIG_PCR_BASE_ADDRESS ==0) : #error "PCR_BASE_ADDRESS need to be non-zero!" : #endif
This does not need to be in a function. Move it above all of this. Also, fi
Actually the build here have something can't be explained. Even CONFIG_PCR_BASE_ADDRESS is not set, hence we can't find it in .config, but eventually in generated config.h, there will be #define CONFIG_PCR_BASE_ADDRESS 0, is that expected or can be explained?