Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33422 )
Change subject: util/inteltool: Clean up PCI assignment ......................................................................
Patch Set 13:
(5 comments)
https://review.coreboot.org/c/coreboot/+/33422/13/util/inteltool/inteltool.c File util/inteltool/inteltool.c:
https://review.coreboot.org/c/coreboot/+/33422/13/util/inteltool/inteltool.c... PS13, Line 716: } else { : fprintf(stderr, "Multiple devices with class ID" : " 0x0601, using %02x%02x:%02x.%02x\n", : sb->domain, sb->bus, sb->dev, sb->func); : break; Why drop this?
https://review.coreboot.org/c/coreboot/+/33422/13/util/inteltool/inteltool.c... PS13, Line 709: for (dev = pacc->devices; dev; dev = dev->next) { Please only scan bus 0, e.g.
if (dev->bus != 0) continue;
https://review.coreboot.org/c/coreboot/+/33422/13/util/inteltool/inteltool.c... PS13, Line 712: if (newdev) { less indentation:
if (!newdev) continue;
https://review.coreboot.org/c/coreboot/+/33422/13/util/inteltool/inteltool.c... PS13, Line 720: case PCI_CLASS_BRIDGE_HOST: Don't indent `case :`
https://review.coreboot.org/c/coreboot/+/33422/13/util/inteltool/inteltool.c... PS13, Line 732: default: free `newdev`?