Change in coreboot[master]: x86/smbios_defaults: Set default system manufacturer for ChromeOS dev... - coreboot-gerrit

15 Mar 2022


      Attention is currently required from: Martin Roth, Matt DeVillier, Tim Wawrzynczak.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62796 )
Change subject: x86/smbios_defaults: Set default system manufacturer for ChromeOS devices
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/smbios_defaults.c:
https://review.coreboot.org/c/coreboot/+/62796/comment/6e0ba03f_73886a17 
PS1, Line 119: 		return "Google";
I would like to avoid vendor specific configurations in common code. In my opinion, This should be done in vendorcode/google/chromeos.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9de17fa12689ab4e627b995818aa3d2653102b04
Gerrit-Change-Number: 62796
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 15 Mar 2022 08:30:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment