[S] Change in coreboot[master]: Revert "mb/starlabs/*: Enable the Mirror flag for boards that support...

[Sean Rhodes (Code Review)]

Attention is currently required from: Angel Pons, Felix Held.

Hello build bot (Jenkins), Angel Pons, Felix Held,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/coreboot/+/72677

to review the following change.

Change subject: Revert "mb/starlabs/*:	Enable the Mirror flag for boards that support it"
......................................................................

Revert "mb/starlabs/*:	Enable the Mirror flag for boards that support it"

This reverts commit 35354583cdc94ced026975ced5170e1c094b258e.

Reason for revert: The mirror flag "0x01" is mirror once, which
relies on the EC remembering that it's been mirrored. However, the
EC forgets this if it's been without power for 20 minutes or so.

Even if power is connected then, it'll instantly try to mirror and
it can't charge whilst doing it. It can either result in
incomplete EC firmware, or a loop where it's constantly trying to mirror.

Change-Id: Ie82cbafd4bea2416526e2847738802a05ed45582
---
M src/mainboard/starlabs/starbook/Kconfig
M src/mainboard/starlabs/starbook/cmos.default
M src/mainboard/starlabs/starbook/cmos.layout
M src/mainboard/starlabs/starbook/variants/tgl/cmos.default
M src/mainboard/starlabs/starbook/variants/tgl/cmos.layout
5 files changed, 19 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/72677/1

diff --git a/src/mainboard/starlabs/starbook/Kconfig b/src/mainboard/starlabs/starbook/Kconfig
index 0854c14..f3f50ad 100644
--- a/src/mainboard/starlabs/starbook/Kconfig
+++ b/src/mainboard/starlabs/starbook/Kconfig
@@ -27,7 +27,6 @@
    select BOARD_ROMSIZE_KB_16384
    select BOARD_STARLABS_STARBOOK_SERIES
    select EC_STARLABS_MAX_CHARGE
-	select EC_STARLABS_MIRROR_FLAG
    select EC_STARLABS_NEED_ITE_BIN
    select HAVE_INTEL_PTT
    select HAVE_SPD_IN_CBFS
@@ -44,7 +43,6 @@
    select DRIVERS_INTEL_USB4_RETIMER
    select EC_STARLABS_KBL_LEVELS
    select EC_STARLABS_MAX_CHARGE
-	select EC_STARLABS_MIRROR_FLAG
    select EC_STARLABS_NEED_ITE_BIN
    select MEMORY_MAPPED_TPM
    select MAINBOARD_HAS_TPM2
diff --git a/src/mainboard/starlabs/starbook/cmos.default b/src/mainboard/starlabs/starbook/cmos.default
index b7f77e4..f1276cc 100644
--- a/src/mainboard/starlabs/starbook/cmos.default
+++ b/src/mainboard/starlabs/starbook/cmos.default
@@ -15,7 +15,6 @@
 # EC
 kbl_timeout=30 seconds
 fn_ctrl_swap=Disable
-mirror_flag=Enable
 # southbridge
 power_on_after_fail=Disable
 # Functions
diff --git a/src/mainboard/starlabs/starbook/cmos.layout b/src/mainboard/starlabs/starbook/cmos.layout
index 8b6a463..887c0b2 100644
--- a/src/mainboard/starlabs/starbook/cmos.layout
+++ b/src/mainboard/starlabs/starbook/cmos.layout
@@ -34,7 +34,6 @@
 608	1	e	1	fn_ctrl_swap
 616	2	e	8	max_charge
 624	2	e	9	fan_mode
-632	1	e	1	mirror_flag

# coreboot config options: southbridge
 800	2	e	6	power_on_after_fail
diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default b/src/mainboard/starlabs/starbook/variants/tgl/cmos.default
index 62bb28d..cfc9a61 100644
--- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default
+++ b/src/mainboard/starlabs/starbook/variants/tgl/cmos.default
@@ -16,7 +16,6 @@
 # EC
 kbl_timeout=30 seconds
 fn_ctrl_swap=Disable
-mirror_flag=Enable
 # southbridge
 power_on_after_fail=Disable
 # Functions
diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout
index d792426..c4a49c5d 100644
--- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout
+++ b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout
@@ -35,7 +35,6 @@
 608	1	e	1	fn_ctrl_swap
 616	2	e	8	max_charge
 624	2	e	9	fan_mode
-632	1	e	1	mirror_flag

# coreboot config options: southbridge
 800	2	e	6	power_on_after_fail