Attention is currently required from: Furquan Shaikh, shkim, SH Kim, Kyösti Mälkki, Edward Doan.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51335 )
Change subject: mb/google/dedede/var/sasuke: Configure I2C times for touchpad/audio
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/mainboard/google/dedede/variants/sasuke/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51335/comment/26e7275c_92a6e489
PS1, Line 66: .scl_lcnt = 190,
Posted some comments on the bug.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51335
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic92ee0379456e80260a8026bc38ee41325dad6d2
Gerrit-Change-Number: 51335
Gerrit-PatchSet: 3
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Edward Doan
edoan@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: shkim
sh_.kim@samsung.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Edward Doan
edoan@google.com
Gerrit-Comment-Date: Tue, 30 Mar 2021 15:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: shkim
sh_.kim@samsung.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment