Attention is currently required from: Felix Held, Jon Murphy, Martin L Roth, Martin Roth.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75588?usp=email )
Change subject: mb/google/myst/bootblock.c: Initialize spi flash
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/myst/bootblock.c:
https://review.coreboot.org/c/coreboot/+/75588/comment/7996d01c_e39e30ad :
PS1, Line 41: // b:285110121 - temp workaround is to add a dummy flash call
Can you add "TODO" so it's easier to grep for this?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75588?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia88d2b46884b096b4c558bc86513159ec6d35eb5
Gerrit-Change-Number: 75588
Gerrit-PatchSet: 2
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Jun 2023 20:51:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Gerrit-MessageType: comment