HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43587 )
Change subject: mb/emulation/qemu-i440fx/northbridge.c: Use macro ......................................................................
mb/emulation/qemu-i440fx/northbridge.c: Use macro
Change-Id: I0297c8c4008d9e448793c38a3758dced9ede0d7e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/emulation/qemu-i440fx/northbridge.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/43587/1
diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 2b7d203..d19d6c8 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -192,10 +192,10 @@ t->size = qemu_get_memory_size() / 1024; t->data_width = 64; t->total_width = 64; - t->form_factor = 9; /* DIMM */ + t->form_factor = MEMORY_FORMFACTOR_DIMM; t->device_locator = smbios_add_string(t->eos, "Virtual"); - t->memory_type = 0x12; /* DDR */ - t->type_detail = 0x80; /* Synchronous */ + t->memory_type = MEMORY_TYPE_DDR; + t->type_detail = MEMORY_TYPE_DETAIL_SYNCHRONOUS; t->speed = 200; t->clock_speed = 200; t->manufacturer = smbios_add_string(t->eos, CONFIG_MAINBOARD_VENDOR);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43587 )
Change subject: mb/emulation/qemu-i440fx/northbridge.c: Use macro ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43587/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43587/1//COMMIT_MSG@7 PS1, Line 7: macro SMBIOS macros
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43587 )
Change subject: mb/emulation/qemu-i440fx/northbridge.c: Use macro ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43587
to look at the new patch set (#2).
Change subject: mb/emulation/qemu-i440fx/northbridge.c: Use SMBIOS macros ......................................................................
mb/emulation/qemu-i440fx/northbridge.c: Use SMBIOS macros
Change-Id: I0297c8c4008d9e448793c38a3758dced9ede0d7e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/emulation/qemu-i440fx/northbridge.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/43587/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43587 )
Change subject: mb/emulation/qemu-i440fx/northbridge.c: Use SMBIOS macros ......................................................................
Patch Set 2:
(1 comment)
Thx
https://review.coreboot.org/c/coreboot/+/43587/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43587/1//COMMIT_MSG@7 PS1, Line 7: macro
SMBIOS macros
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43587 )
Change subject: mb/emulation/qemu-i440fx/northbridge.c: Use SMBIOS macros ......................................................................
mb/emulation/qemu-i440fx/northbridge.c: Use SMBIOS macros
Change-Id: I0297c8c4008d9e448793c38a3758dced9ede0d7e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/43587 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/emulation/qemu-i440fx/northbridge.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 2b7d203..d19d6c8 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -192,10 +192,10 @@ t->size = qemu_get_memory_size() / 1024; t->data_width = 64; t->total_width = 64; - t->form_factor = 9; /* DIMM */ + t->form_factor = MEMORY_FORMFACTOR_DIMM; t->device_locator = smbios_add_string(t->eos, "Virtual"); - t->memory_type = 0x12; /* DDR */ - t->type_detail = 0x80; /* Synchronous */ + t->memory_type = MEMORY_TYPE_DDR; + t->type_detail = MEMORY_TYPE_DETAIL_SYNCHRONOUS; t->speed = 200; t->clock_speed = 200; t->manufacturer = smbios_add_string(t->eos, CONFIG_MAINBOARD_VENDOR);
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)