Selma Bensaid has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43203 )
Change subject: payloads/external: fix depthcharge build from source ......................................................................
payloads/external: fix depthcharge build from source
Signed-off-by: Selma BENSAID selma.bensaid@intel.com Change-Id: I17ae7450a9641268fe392bed0f24846abc8e6f56 --- M payloads/external/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/43203/1
diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index be4b139..ef0990c 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -19,7 +19,7 @@ ifeq ($(CONFIG_PAYLOAD_DEPTHCHARGE),y) PAYLOAD_CONFIG=payloads/external/depthcharge/depthcharge/.config $(PAYLOAD_CONFIG): payloads/external/depthcharge/depthcharge/build/depthcharge.elf -ifeq ($(call strip_quotes,$(CONFIG_MAINBOARD_DEPTHCHARGE))),) +ifeq ($(call strip_quotes,$(CONFIG_MAINBOARD_DEPTHCHARGE)),) BOARD=$(call ws_to_under,$(call strip_quotes,$(call tolower,$(CONFIG_MAINBOARD_PART_NUMBER)))) else BOARD=$(CONFIG_MAINBOARD_DEPTHCHARGE)
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43203 )
Change subject: payloads/external: fix depthcharge build from source ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43203 )
Change subject: payloads/external: fix depthcharge build from source ......................................................................
payloads/external: fix depthcharge build from source
Signed-off-by: Selma BENSAID selma.bensaid@intel.com Change-Id: I17ae7450a9641268fe392bed0f24846abc8e6f56 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43203 Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M payloads/external/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index be4b139..ef0990c 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -19,7 +19,7 @@ ifeq ($(CONFIG_PAYLOAD_DEPTHCHARGE),y) PAYLOAD_CONFIG=payloads/external/depthcharge/depthcharge/.config $(PAYLOAD_CONFIG): payloads/external/depthcharge/depthcharge/build/depthcharge.elf -ifeq ($(call strip_quotes,$(CONFIG_MAINBOARD_DEPTHCHARGE))),) +ifeq ($(call strip_quotes,$(CONFIG_MAINBOARD_DEPTHCHARGE)),) BOARD=$(call ws_to_under,$(call strip_quotes,$(call tolower,$(CONFIG_MAINBOARD_PART_NUMBER)))) else BOARD=$(CONFIG_MAINBOARD_DEPTHCHARGE)
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43203 )
Change subject: payloads/external: fix depthcharge build from source ......................................................................
Patch Set 2:
(1 comment)
Does this need to be backported to the 4.11_branch?
$ git tag --contains 6aa81fa55e46a308e78506d6ee93a61fb569b6c6 4.11 4.12
https://review.coreboot.org/c/coreboot/+/43203/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43203/2//COMMIT_MSG@8 PS2, Line 8: So this fixed a regression?
Fixes: 6aa81fa55e (Fix sarien depthcharge make build)
Selma Bensaid has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43203 )
Change subject: payloads/external: fix depthcharge build from source ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43203/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43203/2//COMMIT_MSG@8 PS2, Line 8:
So this fixed a regression? […]
yes
-
Patrick Georgi (Code Review) -
Paul Menzel (Code Review)
-
Selma Bensaid (Code Review)