Attention is currently required from: Kapil Porwal, Paul Menzel, Subrata Banik.
Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/85219?usp=email )
Change subject: src/soc/intel/cmn/blk/cse: Log cse sync information
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/85219/comment/dfb038c1_96e3ac50?usp... :
PS2, Line 809: elog_add_event_byte(ELOG_TYPE_FW_CSE_SYNC, CONFIG(SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE)?
`spaces required around that '?' (ctx:VxE)` […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/85219/comment/ae23b270_02f42391?usp... :
PS2, Line 810: ELOG_FW_LATE_CSE_SYNC:ELOG_FW_EARLY_CSE_SYNC);
`labels should not be indented` […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85219?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idece841c2b069d7688afc258470667ed2851a282
Gerrit-Change-Number: 85219
Gerrit-PatchSet: 3
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 18 Dec 2024 05:52:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com