Attention is currently required from: Raul Rangel.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67191 )
Change subject: util/lint/lint: Add command line parsing ......................................................................
Patch Set 1:
(3 comments)
File util/lint/lint:
https://review.coreboot.org/c/coreboot/+/67191/comment/05734e95_b6601a42 PS1, Line 21: $(getopt -l help,junit -o hJ -- "$@")
quotes
Done
https://review.coreboot.org/c/coreboot/+/67191/comment/53131f54_25fbaa76 PS1, Line 25: if [ ${getopt_ret} -ne 0 ]; then
You could do: […]
Done
https://review.coreboot.org/c/coreboot/+/67191/comment/f57b6112_ccffea55 PS1, Line 51: [
nit: Add an extra indent so it doesn't look like it's part of the block
Done
-
Martin L Roth (Code Review)