Change in ...coreboot[master]: UPSTREAM: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Casper Chang (Code Review)

4 Mar 2019 4 Mar '19

3:58 p.m.

Casper Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31705

Change subject: UPSTREAM: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT ......................................................................

UPSTREAM: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Follow b:123342945 to add GPIO H15(BT_RADIO_DIS#).

BUG=b:123342945 TEST=Built and tested on sarien system

Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 --- M 3rdparty/vboot M src/mainboard/google/sarien/variants/arcada/gpio.c 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31705/1

diff --git a/3rdparty/vboot b/3rdparty/vboot index 1e17774..a32c930 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 1e177741c3a9bfb8bd69a92b6d3bf4b25655a71f +Subproject commit a32c930e8c46424a3bba3c296fd78b3e60f50aeb diff --git a/src/mainboard/google/sarien/variants/arcada/gpio.c b/src/mainboard/google/sarien/variants/arcada/gpio.c index a29fd06..cfd35b9 100644 --- a/src/mainboard/google/sarien/variants/arcada/gpio.c +++ b/src/mainboard/google/sarien/variants/arcada/gpio.c @@ -214,7 +214,7 @@ /* M2_SKT2_CFG0 */ PAD_NC(GPP_H12, NONE), /* M2_SKT2_CFG1 */ PAD_NC(GPP_H13, NONE), /* M2_SKT2_CFG2 */ PAD_NC(GPP_H14, NONE), -/* M2_SKT2_CFG3 */ PAD_NC(GPP_H15, NONE), +/* M2_SKT2_CFG3 */ PAD_CFG_GPO(GPP_H15, 1, DEEP), /* BT_RADIO_DIS# */ /* DDPF_CTRLCLK */ PAD_NC(GPP_H16, NONE), /* DPPF_CTRLDATA */ PAD_NC(GPP_H17, NONE), /* CPU_C10_GATE# */ PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* C10_GATE# */

Attachments:

attachment.htm (text/html — 3.2 KB)

Show replies by date

Casper Chang (Code Review)

4 Mar 4 Mar

4 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31705

to look at the new patch set (#2).

Change subject: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT ......................................................................

mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Follow b:123342945 to add GPIO H15(BT_RADIO_DIS#).

BUG=b:123342945 TEST=Built and tested on sarien system

Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 --- M 3rdparty/vboot M src/mainboard/google/sarien/variants/arcada/gpio.c 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31705/2

Casper Chang (Code Review)

4:01 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31705

to look at the new patch set (#3).

Change subject: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT ......................................................................

mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Follow b:123342945 to add GPIO H15(BT_RADIO_DIS#).

BUG=b:123342945 TEST=WIP

Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 --- M 3rdparty/vboot M src/mainboard/google/sarien/variants/arcada/gpio.c 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31705/3

Casper Chang (Code Review)

4:02 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31705

to look at the new patch set (#4).

Change subject: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT ......................................................................

mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Follow b:123342945 to add GPIO H15(BT_RADIO_DIS#).

BUG=b:123342945 TEST=WIP

Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 --- M 3rdparty/vboot M src/mainboard/google/sarien/variants/arcada/gpio.c 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31705/4

Casper Chang (Code Review)

4:58 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31705

to look at the new patch set (#5).

Change subject: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT ......................................................................

mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Follow b:123342945 to add GPIO H15(BT_RADIO_DIS#).

BUG=b:123342945 TEST=WIP

Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 --- M src/mainboard/google/sarien/variants/arcada/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31705/5

Casper Chang (Code Review)

5 Mar 5 Mar

2:11 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31705 )

Change subject: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT ......................................................................

Patch Set 5:

verified

-- To view, visit https://review.coreboot.org/c/coreboot/+/31705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 Gerrit-Change-Number: 31705 Gerrit-PatchSet: 5 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 05 Mar 2019 03:11:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Casper Chang (Code Review)

2:14 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT Follow b:...

Hello Duncan Laurie, Lijian Zhao, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31705

to look at the new patch set (#6).

Change subject: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT Follow b:123342945 to add GPIO H15(BT_RADIO_DIS#). ......................................................................

mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT Follow b:123342945 to add GPIO H15(BT_RADIO_DIS#).

BUG=b:123342945 TEST=test BT function on Arcada DVT1 system

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31705/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/31705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 Gerrit-Change-Number: 31705 Gerrit-PatchSet: 6 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Casper Chang (Code Review)

2:15 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT Follow b:...

Hello Duncan Laurie, Lijian Zhao, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31705

to look at the new patch set (#7).

Change subject: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT Follow b:123342945 to add GPIO H15(BT_RADIO_DIS#). ......................................................................

mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT Follow b:123342945 to add GPIO H15(BT_RADIO_DIS#).

BUG=b:123342945 TEST=Verified BT function on Arcada DVT1 system

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31705/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/31705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 Gerrit-Change-Number: 31705 Gerrit-PatchSet: 7 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Casper Chang (Code Review)

2:16 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Hello Duncan Laurie, build bot (Jenkins), Lijian Zhao, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31705

to look at the new patch set (#8).

Change subject: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT ......................................................................

mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Follow b:123342945 to add GPIO H15(BT_RADIO_DIS#).

BUG=b:123342945 TEST=Verified BT function on Arcada DVT1 system

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/31705/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/31705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 Gerrit-Change-Number: 31705 Gerrit-PatchSet: 8 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Lijian Zhao (Code Review)

7:22 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31705 )

Change subject: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 Gerrit-Change-Number: 31705 Gerrit-PatchSet: 8 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 05 Mar 2019 08:22:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

7:28 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31705 )

Change subject: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 Gerrit-Change-Number: 31705 Gerrit-PatchSet: 8 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 05 Mar 2019 08:28:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Duncan Laurie (Code Review)

7:28 p.m.

New subject: Change in ...coreboot[master]: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31705 )

Change subject: mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT ......................................................................

mb/google/sarien/variants/arcada: Add GPIO H15 to enable BT

Follow b:123342945 to add GPIO H15(BT_RADIO_DIS#).

BUG=b:123342945 TEST=Verified BT function on Arcada DVT1 system

Signed-off-by: Casper Chang casper_chang@wistron.corp-partner.google.com Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/31705 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Lijian Zhao lijian.zhao@intel.com Reviewed-by: Duncan Laurie dlaurie@chromium.org --- M src/mainboard/google/sarien/variants/arcada/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Lijian Zhao: Looks good to me, approved

diff --git a/src/mainboard/google/sarien/variants/arcada/gpio.c b/src/mainboard/google/sarien/variants/arcada/gpio.c index a29fd06..1b06301 100644 --- a/src/mainboard/google/sarien/variants/arcada/gpio.c +++ b/src/mainboard/google/sarien/variants/arcada/gpio.c @@ -214,7 +214,7 @@ /* M2_SKT2_CFG0 */ PAD_NC(GPP_H12, NONE), /* M2_SKT2_CFG1 */ PAD_NC(GPP_H13, NONE), /* M2_SKT2_CFG2 */ PAD_NC(GPP_H14, NONE), -/* M2_SKT2_CFG3 */ PAD_NC(GPP_H15, NONE), +/* M2_SKT2_CFG3 */ PAD_CFG_GPO(GPP_H15, 1, DEEP), /* BT_RADIO_DIS# */ /* DDPF_CTRLCLK */ PAD_NC(GPP_H16, NONE), /* DPPF_CTRLDATA */ PAD_NC(GPP_H17, NONE), /* CPU_C10_GATE# */ PAD_CFG_NF(GPP_H18, NONE, DEEP, NF1), /* C10_GATE# */

-- To view, visit https://review.coreboot.org/c/coreboot/+/31705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I260a2312d47385da3c7ec215267ff63ada04f2c5 Gerrit-Change-Number: 31705 Gerrit-PatchSet: 9 Gerrit-Owner: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Casper Chang casper_chang@wistron.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2043

days inactive

2044

days old

coreboot-gerrit@coreboot.org

11 comments

3 participants

tags (0)

participants (3)

Casper Chang (Code Review)
Duncan Laurie (Code Review)
Lijian Zhao (Code Review)