Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48140 )
Change subject: mb/kontron/mal10/Kconfig: Reorder selects alphabetically ......................................................................
mb/kontron/mal10/Kconfig: Reorder selects alphabetically
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Id78c478a1252099cd1aa42c62efd406e7e1c5ef8 --- M src/mainboard/kontron/mal10/Kconfig 1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/48140/1
diff --git a/src/mainboard/kontron/mal10/Kconfig b/src/mainboard/kontron/mal10/Kconfig index 1705b91..f53746d 100644 --- a/src/mainboard/kontron/mal10/Kconfig +++ b/src/mainboard/kontron/mal10/Kconfig @@ -2,18 +2,18 @@
config BOARD_SPECIFIC_OPTIONS def_bool y + select BOARD_ROMSIZE_KB_16384 + select DRIVERS_I2C_NCT7802Y + select EC_KONTRON_KEMPLD select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME - select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_GMA_HAVE_VBT - select SOC_INTEL_APOLLOLAKE - select BOARD_ROMSIZE_KB_16384 - select ONBOARD_VGA_IS_PRIMARY - select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_CRB_TPM - select EC_KONTRON_KEMPLD - select DRIVERS_I2C_NCT7802Y + select MAINBOARD_HAS_LIBGFXINIT + select ONBOARD_VGA_IS_PRIMARY + select SOC_INTEL_APOLLOLAKE
config MAINBOARD_DIR string
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48140 )
Change subject: mb/kontron/mal10/Kconfig: Reorder selects alphabetically ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Maxim Polyakov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48140
to look at the new patch set (#2).
Change subject: mb/kontron/mal10/Kconfig: Reorder selects alphabetically ......................................................................
mb/kontron/mal10/Kconfig: Reorder selects alphabetically
Built with BUILD_TIMELESS=1, coreboot.rom remains the same.
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Id78c478a1252099cd1aa42c62efd406e7e1c5ef8 --- M src/mainboard/kontron/mal10/Kconfig 1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/48140/2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48140 )
Change subject: mb/kontron/mal10/Kconfig: Reorder selects alphabetically ......................................................................
mb/kontron/mal10/Kconfig: Reorder selects alphabetically
Built with BUILD_TIMELESS=1, coreboot.rom remains the same.
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: Id78c478a1252099cd1aa42c62efd406e7e1c5ef8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48140 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/kontron/mal10/Kconfig 1 file changed, 7 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/mainboard/kontron/mal10/Kconfig b/src/mainboard/kontron/mal10/Kconfig index 1705b91..f53746d 100644 --- a/src/mainboard/kontron/mal10/Kconfig +++ b/src/mainboard/kontron/mal10/Kconfig @@ -2,18 +2,18 @@
config BOARD_SPECIFIC_OPTIONS def_bool y + select BOARD_ROMSIZE_KB_16384 + select DRIVERS_I2C_NCT7802Y + select EC_KONTRON_KEMPLD select HAVE_ACPI_TABLES select HAVE_ACPI_RESUME - select HAVE_OPTION_TABLE select HAVE_CMOS_DEFAULT + select HAVE_OPTION_TABLE select INTEL_GMA_HAVE_VBT - select SOC_INTEL_APOLLOLAKE - select BOARD_ROMSIZE_KB_16384 - select ONBOARD_VGA_IS_PRIMARY - select MAINBOARD_HAS_LIBGFXINIT select MAINBOARD_HAS_CRB_TPM - select EC_KONTRON_KEMPLD - select DRIVERS_I2C_NCT7802Y + select MAINBOARD_HAS_LIBGFXINIT + select ONBOARD_VGA_IS_PRIMARY + select SOC_INTEL_APOLLOLAKE
config MAINBOARD_DIR string
-
Felix Singer (Code Review) -
Frans Hendriks (Code Review)
-
Patrick Georgi (Code Review)