Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42622 )
Change subject: sb/intel/wildcatpoint/iobp.c: Align with Lynxpoint ......................................................................
sb/intel/wildcatpoint/iobp.c: Align with Lynxpoint
Change-Id: I759aa98b80c70c5024213bd8795375061bdbbf10 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/wildcatpoint/iobp.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/42622/1
diff --git a/src/southbridge/intel/wildcatpoint/iobp.c b/src/southbridge/intel/wildcatpoint/iobp.c index 72cb111..51dd8a6 100644 --- a/src/southbridge/intel/wildcatpoint/iobp.c +++ b/src/southbridge/intel/wildcatpoint/iobp.c @@ -93,10 +93,10 @@ status = RCBA16(IOBPS); if (status & IOBPS_TX_MASK) { printk(BIOS_ERR, "IOBP: write 0x%08x failed\n", address); - //return; + return; }
- //printk(BIOS_INFO, "IOBP: set 0x%08x to 0x%08x\n", address, data); + printk(BIOS_INFO, "IOBP: set 0x%08x to 0x%08x\n", address, data); }
void pch_iobp_update(u32 address, u32 andvalue, u32 orvalue)
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42622
to look at the new patch set (#4).
Change subject: sb/intel/wildcatpoint/iobp.c: Align with Lynxpoint ......................................................................
sb/intel/wildcatpoint/iobp.c: Align with Lynxpoint
Change-Id: I759aa98b80c70c5024213bd8795375061bdbbf10 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/wildcatpoint/iobp.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/42622/4
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42622
to look at the new patch set (#7).
Change subject: sb/intel/wildcatpoint/iobp.c: Align with Lynxpoint ......................................................................
sb/intel/wildcatpoint/iobp.c: Align with Lynxpoint
Change-Id: I759aa98b80c70c5024213bd8795375061bdbbf10 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/southbridge/intel/wildcatpoint/iobp.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/42622/7
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42622
to look at the new patch set (#8).
Change subject: soc/intel/broadwell/iobp.c: Align with Lynxpoint ......................................................................
soc/intel/broadwell/iobp.c: Align with Lynxpoint
Change-Id: I759aa98b80c70c5024213bd8795375061bdbbf10 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/iobp.c 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/42622/8
Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Tim Wawrzynczak, Arthur Heymans, Aaron Durbin, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42622
to look at the new patch set (#13).
Change subject: soc/intel/broadwell/iobp.c: Add debug print ......................................................................
soc/intel/broadwell/iobp.c: Add debug print
This reduces the differences between Lynxpoint and Broadwell.
Change-Id: I759aa98b80c70c5024213bd8795375061bdbbf10 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/iobp.c 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/42622/13
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42622 )
Change subject: soc/intel/broadwell/iobp.c: Add debug print ......................................................................
Patch Set 14: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42622 )
Change subject: soc/intel/broadwell/iobp.c: Add debug print ......................................................................
Patch Set 14: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42622/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42622/14//COMMIT_MSG@7 PS14, Line 7: debug It’s BIOS_INFO.
Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Paul Menzel, Tim Wawrzynczak, Arthur Heymans, Aaron Durbin, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42622
to look at the new patch set (#15).
Change subject: soc/intel/broadwell/iobp.c: Add another `printk` ......................................................................
soc/intel/broadwell/iobp.c: Add another `printk`
This reduces the differences between Lynxpoint and Broadwell.
Change-Id: I759aa98b80c70c5024213bd8795375061bdbbf10 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/iobp.c 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/42622/15
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42622 )
Change subject: soc/intel/broadwell/iobp.c: Add another `printk` ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42622/14//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42622/14//COMMIT_MSG@7 PS14, Line 7: debug
It’s BIOS_INFO.
`info print` sounds horrible.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42622 )
Change subject: soc/intel/broadwell/iobp.c: Add another `printk` ......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42622/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42622/15//COMMIT_MSG@7 PS15, Line 7: soc/intel/broadwell/iobp.c: Add another `printk`
soc/intel/broadwell/iobp: Log success in `pch_iobp_write()`
Hello build bot (Jenkins), Nico Huber, Frans Hendriks, Paul Menzel, Tim Wawrzynczak, Arthur Heymans, Aaron Durbin, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42622
to look at the new patch set (#16).
Change subject: soc/intel/broadwell/iobp: Log success in `pch_iobp_write()` ......................................................................
soc/intel/broadwell/iobp: Log success in `pch_iobp_write()`
This reduces the differences between Lynxpoint and Broadwell.
Change-Id: I759aa98b80c70c5024213bd8795375061bdbbf10 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/iobp.c 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/42622/16
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42622 )
Change subject: soc/intel/broadwell/iobp: Log success in `pch_iobp_write()` ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42622/15//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42622/15//COMMIT_MSG@7 PS15, Line 7: soc/intel/broadwell/iobp.c: Add another `printk`
soc/intel/broadwell/iobp: Log success in `pch_iobp_write()`
Done, thanks for the suggestion
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42622 )
Change subject: soc/intel/broadwell/iobp: Log success in `pch_iobp_write()` ......................................................................
Patch Set 16: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42622 )
Change subject: soc/intel/broadwell/iobp: Log success in `pch_iobp_write()` ......................................................................
soc/intel/broadwell/iobp: Log success in `pch_iobp_write()`
This reduces the differences between Lynxpoint and Broadwell.
Change-Id: I759aa98b80c70c5024213bd8795375061bdbbf10 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42622 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/broadwell/iobp.c 1 file changed, 5 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/iobp.c b/src/soc/intel/broadwell/iobp.c index 76a3e58..ffa61fb 100644 --- a/src/soc/intel/broadwell/iobp.c +++ b/src/soc/intel/broadwell/iobp.c @@ -91,8 +91,12 @@
/* Check for successful transaction */ status = RCBA16(IOBPS); - if (status & IOBPS_TX_MASK) + if (status & IOBPS_TX_MASK) { printk(BIOS_ERR, "IOBP: write 0x%08x failed\n", address); + return; + } + + printk(BIOS_INFO, "IOBP: set 0x%08x to 0x%08x\n", address, data); }
void pch_iobp_update(u32 address, u32 andvalue, u32 orvalue)
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Paul Menzel (Code Review)
-
Tim Wawrzynczak (Code Review)