Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34683 )
Change subject: soc/intel/fsp_broadwell_de: Enable early integrated UART ......................................................................
Patch Set 11:
(7 comments)
https://review.coreboot.org/c/coreboot/+/34683/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34683/2//COMMIT_MSG@10 PS2, Line 10: down
… knocking down what? […]
Ack
https://review.coreboot.org/c/coreboot/+/34683/2//COMMIT_MSG@12 PS2, Line 12: TEST=check if printk() show up in early romstage
On what board?
Ack
https://review.coreboot.org/c/coreboot/+/34683/2/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/Kconfig:
https://review.coreboot.org/c/coreboot/+/34683/2/src/soc/intel/fsp_broadwell... PS2, Line 76:
I only have one board to test at the moment. […]
Ack
https://review.coreboot.org/c/coreboot/+/34683/2/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/include/soc/ubox.h:
https://review.coreboot.org/c/coreboot/+/34683/2/src/soc/intel/fsp_broadwell... PS2, Line 4: * Copyright (C) 2019 Facebook, Inc
Inc.
Ack
https://review.coreboot.org/c/coreboot/+/34683/2/src/soc/intel/fsp_broadwell... PS2, Line 20: #define UBOX_UART_ENABLE_PORT0 (1<<0)
Please add spaces around the operator.
Ack
https://review.coreboot.org/c/coreboot/+/34683/2/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/include/soc/vtd.h:
https://review.coreboot.org/c/coreboot/+/34683/2/src/soc/intel/fsp_broadwell... PS2, Line 4: * Copyright (C) 2019 Facebook, Inc
Inc.
Ack
https://review.coreboot.org/c/coreboot/+/34683/2/src/soc/intel/fsp_broadwell... PS2, Line 19: #define VTD_CPUBUSNO 0x108
Use tabs for alignment?
Ack
-
Andrey Petrov (Code Review)