Attention is currently required from: Michael Niewöhner, Nicholas Chin, Nicholas Sudsgaard.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80452?usp=email )
Change subject: include/device/azalia_device.h: Add enum for misc field
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80452/comment/b9d24bcd_230ea33e :
PS4, Line 17: Currently only mb/clevo/tgl-u/variants/l140mu uses the AZALIA_PIN_DESC
: macro and has been updated to use the new enum. Other boards can be bulk
: processed to switch from bare register values to the macro and enums in
: a future patch.
:
I would rather have that in a separate commit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80452?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I70cbfca8541828a1e0c7280887060c04e4c71721
Gerrit-Change-Number: 80452
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Tue, 13 Feb 2024 18:32:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment