Attention is currently required from: Eric Lai, Kapil Porwal, Ronak Kanabar, Subrata Banik, V Sowmya, Varun Upadhyay.
Paul Menzel has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/83404?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: vc/intel/fsp: Update twinlake FSP headers from v5142.00 to v5222.01
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83404/comment/bfc0d5bc_bcc4792d?usp... :
PS3, Line 7: vc/intel/fsp: Update twinlake FSP headers from v5142.00 to v5222.01
Maybe:
vc/intel/fsp/twinlake: Update FSP headers from v5142.00 to v5222.01
https://review.coreboot.org/c/coreboot/+/83404/comment/75725c0a_38f82830?usp... :
PS3, Line 9: twinlake
Twin Lake
https://review.coreboot.org/c/coreboot/+/83404/comment/a521a5fa_72b2c6d6?usp... :
PS3, Line 12: - Open Usb4CmMode & CnviWifiCore Upd in FspsUpd.h
What do you mean by open?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83404?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia68b6aa90c782a359b594f381e223772a897c6e6
Gerrit-Change-Number: 83404
Gerrit-PatchSet: 3
Gerrit-Owner: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Comment-Date: Fri, 26 Jul 2024 12:21:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No