Change in coreboot[master]: treewide: Remove unused spinlock functions

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Nico Huber, Marshall Dawson, Julius Werner, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59020 )

Change subject: treewide: Remove unused spinlock functions
......................................................................

Patch Set 2: Code-Review-1

(2 comments)

Patchset:

PS2: 
Not addressing the rootcause of CONFIG(SMP) evaluating incorrectly for psp_verstagte, fixing of which would remove the entire file this touches psp_verstage ... smp/spinlock.h.

If you ask me, spin_lock() should only do the spinlock and solution to co-operative multitasking might want the functions removed here. There's really no harm that they exist in the header?

File src/soc/amd/common/psp_verstage/include/arch/smp/spinlock.h:

https://review.coreboot.org/c/coreboot/+/59020/comment/985fa454_1a22b402 
PS2, Line 8: #define spin_unlock(lock)	do {} while (0)
> Just FYI, the following diff allows the psp_verstage spinlock.h to be removed: […]

Thanks. You need the config with CMOS_POST=y apparently to make it fail.