Hello build bot (Jenkins), Patrick Georgi, Furquan Shaikh,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42583
to review the following change.
Change subject: Revert "Mushu: Enable PCIe 1d.4 to enable dgpu" ......................................................................
Revert "Mushu: Enable PCIe 1d.4 to enable dgpu"
This reverts commit 1408798637125f1707ded7215e22461c623a79a8.
Reason for revert: Causing backlight issues in device. Will reland after more debugging to figure out the root cause.
BUG=b:159370566 BRANCH=None TEST=boot up device and make sure when kernel is booted, backlight comes up.
Change-Id: I643854c6c805d262539bbb482808e8c322059a49 --- M src/mainboard/google/hatch/variants/mushu/overridetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42583/1
diff --git a/src/mainboard/google/hatch/variants/mushu/overridetree.cb b/src/mainboard/google/hatch/variants/mushu/overridetree.cb index 100f7d5..db86d68 100644 --- a/src/mainboard/google/hatch/variants/mushu/overridetree.cb +++ b/src/mainboard/google/hatch/variants/mushu/overridetree.cb @@ -185,7 +185,6 @@ device i2c 1a on end end end #I2C #4 - device pci 1d.4 on end # PCI Express port 13 device pci 1e.3 on chip drivers/spi/acpi register "name" = ""CRFP""
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42583 )
Change subject: Revert "Mushu: Enable PCIe 1d.4 to enable dgpu" ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42583
to look at the new patch set (#2).
Change subject: Revert "Mushu: Enable PCIe 1d.4 to enable dgpu" ......................................................................
Revert "Mushu: Enable PCIe 1d.4 to enable dgpu"
This reverts commit 1408798637125f1707ded7215e22461c623a79a8.
Reason for revert: Causing backlight issues in device. Will reland after more debugging to figure out the root cause.
BUG=b:159370566 BRANCH=None TEST=boot up device and make sure when kernel is booted, backlight comes up.
Change-Id: I643854c6c805d262539bbb482808e8c322059a49 Signed-off-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/variants/mushu/overridetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/42583/2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42583 )
Change subject: Revert "Mushu: Enable PCIe 1d.4 to enable dgpu" ......................................................................
Patch Set 2: Code-Review+2
Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42583 )
Change subject: Revert "Mushu: Enable PCIe 1d.4 to enable dgpu" ......................................................................
Revert "Mushu: Enable PCIe 1d.4 to enable dgpu"
This reverts commit 1408798637125f1707ded7215e22461c623a79a8.
Reason for revert: Causing backlight issues in device. Will reland after more debugging to figure out the root cause.
BUG=b:159370566 BRANCH=None TEST=boot up device and make sure when kernel is booted, backlight comes up.
Change-Id: I643854c6c805d262539bbb482808e8c322059a49 Signed-off-by: Shelley Chen shchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42583 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M src/mainboard/google/hatch/variants/mushu/overridetree.cb 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Shelley Chen: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/mushu/overridetree.cb b/src/mainboard/google/hatch/variants/mushu/overridetree.cb index 100f7d5..db86d68 100644 --- a/src/mainboard/google/hatch/variants/mushu/overridetree.cb +++ b/src/mainboard/google/hatch/variants/mushu/overridetree.cb @@ -185,7 +185,6 @@ device i2c 1a on end end end #I2C #4 - device pci 1d.4 on end # PCI Express port 13 device pci 1e.3 on chip drivers/spi/acpi register "name" = ""CRFP""
-
Shelley Chen (Code Review) -
Stefan Reinauer (Code Review)